Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4953+4965: Angular input implementing and refactoring tests #5058

Merged
merged 9 commits into from
Dec 21, 2023

Conversation

b14ckster
Copy link
Contributor

No description provided.

@vklonin
Copy link
Contributor

vklonin commented Sep 8, 2023

Так же предлагаю подумать какие еще свойства или методы можно добавить для удобства тестирования сайта на котором есть элементы Input
Может быть для этого нужно что то добавить на тестовый сайт - если да то заведи задачку на это действие

Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом, кроме Input нужен именно сложный элемент типа FormField, в котором уже сделать все подписи, кнопочки, префиксы и ошибки валидации
И не надо писать тесты просто для того, чтобы они были

@b14ckster b14ckster force-pushed the angular_input_refactoring branch from 23ca9a5 to cd53b9f Compare September 19, 2023 12:35
@b14ckster b14ckster force-pushed the angular_input_refactoring branch from 0e32445 to a5b94e6 Compare October 13, 2023 15:02
@MayaElf MayaElf force-pushed the angular_input_refactoring branch from a5b94e6 to 34bc184 Compare October 18, 2023 13:56
@MayaElf MayaElf changed the title 4953+4965: Angular input implementing and refactoring tests [WIP]4953+4965: Angular input implementing and refactoring tests Oct 18, 2023
@MayaElf MayaElf removed their request for review October 19, 2023 11:28
@MayaElf MayaElf assigned MayaElf and unassigned MayaElf Oct 19, 2023
@kira-vlsv kira-vlsv changed the title [WIP]4953+4965: Angular input implementing and refactoring tests 4953+4965: Angular input implementing and refactoring tests Dec 18, 2023
@vklonin vklonin merged commit 786e1c9 into angular_rework_development Dec 21, 2023
7 checks passed
@vklonin vklonin deleted the angular_input_refactoring branch December 21, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create class implementing angular element Input Tests refactoring: input element
5 participants