-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery .height() and .width() don't include padding and border #14
Comments
It is better to use jQuery-style: splitter.outerWidth() and splitter.outerHeight() to include padding and border. |
Regardless the current version of this splitter is useless without this fix. Do you guys have a modified version that fixes this? I don't see anything forked. |
It seems that on January 23, 2014 plashenkov introduced usage of |
Created a pull request to fix this issue, see my branch patch-1 |
Hey @kriede do you want to merge this with original jcubic/jQuery.Splitter because you created pull reqest to the fork? |
Yes, would be good to have it in the original branch. |
jQuery
.height()
and.width()
are not equivalent tooffsetHeight
andoffsetWidth
since they don't include padding and border.If we want to override the default splitter style with padding and border, the calculated height and width will be incorrect.
You can replace
splitter.width()
andsplitter.height()
withsplitter.get(0).offsetWidth
andsplitter.get(0).offsetHeight
, respectively, to overcome this issue.The text was updated successfully, but these errors were encountered: