Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaFX support #133

Closed
simlei opened this issue Jan 18, 2019 · 4 comments
Closed

JavaFX support #133

simlei opened this issue Jan 18, 2019 · 4 comments

Comments

@simlei
Copy link
Member

simlei commented Jan 18, 2019

It would be nice to be able to mix in JavaFX-based controls into JCT -- but it should be explored first what implication this has on the Target Platform configuration, and whether it works on all platforms out of the box (we do not want to have builds fail or the product fail to launch by introducing this dependency)

Initial exploration on my fork and of tassadarius' fork has been done and will continue in a string of PRs:

simlei#2
tassadarius#1

At this point, it looks like we can use JavaFX-based UI elements in JCT in a development environment, using the ef(x)clipse project and target definitions.
On my machine (Linux/Ubuntu 16.04/Eclipse Photon 2018-09) I still have problems in pulling in JavaFX binaries at runtime. Still my most recent PR seems to work for @tassadarius (Windows/Eclipse Photon 2018-12)

  1. get it running in development environment on my machine, find out what's stopping it now and if that would be a common source of problems for others on Linux.
  2. If everything works smoothly in development, build a JCT product with Maven where single JavaFX-based plugin can be dropped into $JCT_WORKSPACE/dropins
  3. Ascertain usefulness of JavaFX -- do we want this extra dependency in JCT?

if yes to 3)

  1. Test 3) on all platforms (Windows 8,10, Ubuntu, OSX), on completion, merge w/ core/develop s.t. weekly builds get built like the separate JavaFX-build in 3)

"ping" @tassadarius for feedback

@simlei
Copy link
Member Author

simlei commented Oct 13, 2019

We're moving to Java 11 which is supposed to ship JavaFX.

Tom Schindl seems to be the main man for javafx packaging and delivery, and seems to be active also in the Eclipse Forums. Here is his blog post on OpenJDK 11, JavaFX

He recommends shipping JavaFX with a JLink runtime environment (good thing we use that now, too, TODO JLink issue).

I do not know of any plugin that currently needs JavaFX support, so I suppose this can wait for after the release of v.1.0-final.

other relevant eclipse forums discussion

@simlei
Copy link
Member Author

simlei commented Jan 26, 2021

Does anyone still need JavaFX?

@grthor
Copy link
Member

grthor commented Jan 26, 2021

I do not need it. It would be nice if the JCT would support it to be able to implement more beautiful graphics, but for now SWT is enough.

If anyone needs JavaFx, he can implement it. However, since there is no specific demand for it, I would not invest the time in the implementation.

Would suggest to close this issue.

@simlei
Copy link
Member Author

simlei commented Jan 26, 2021

I agree; closing this until someone approaches with concrete JavaFX-related needs.

@simlei simlei closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants