Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-2141 NID compliance #20

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

RFC-2141 NID compliance #20

wants to merge 9 commits into from

Conversation

eedzjee
Copy link

@eedzjee eedzjee commented Oct 27, 2020

According to chapter 2.1 in the RFC-2141, the NID can contain up to 32 characters, numbers and hyphens. With the first character not to be a hyphen: https://www.ietf.org/rfc/rfc2141.txt

I've fixed this in the URN.java class and added tests for them. I tried to fix all qulice warnings, but couldn't comply with the 'AbbreviationAsWordInNameCheck' of the URN class itself as it would break the library's compliancy.

Also some dependencies could be updated in the parents as they haven't been changed in a while.

@0crat
Copy link

0crat commented Oct 27, 2020

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@eedzjee
Copy link
Author

eedzjee commented Oct 27, 2020

I fixed the build, but was unable to suppress the Checkstyle warnings about 'AbbreviationAsWordInNameCheck':

Checkstyle: C:\projects\jcabi-urn\src\main\java\com\jcabi\urn\URN.java[69]: Abbreviation in name 'URN' must contain no more than '2' consecutive capital letters. (AbbreviationAsWordInNameCheck)
[INFO] Checkstyle: C:\projects\jcabi-urn\src\main\java\com\jcabi\urn\URN.java[233]: Abbreviation in name 'toURI' must contain no more than '2' consecutive capital letters. (AbbreviationAsWordInNameCheck)

Do you know how to do this @yegor256 ? Adding @SuppressWarnings("checkstyle:abbreviationaswordinname") doesn't seem to help.

@eedzjee
Copy link
Author

eedzjee commented Oct 27, 2020

assign @yegor256

@0crat
Copy link

0crat commented Nov 1, 2020

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Nov 6, 2020

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Nov 11, 2020

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Dec 27, 2020

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jan 1, 2021

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jan 6, 2021

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jan 11, 2021

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jan 16, 2021

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jan 21, 2021

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jan 26, 2021

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jan 31, 2021

@yegor256/z everybody who has role REV is banned at #20; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants