-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-2141 NID compliance #20
Open
eedzjee
wants to merge
9
commits into
jcabi:master
Choose a base branch
from
eedzjee:nid-compliance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed the build, but was unable to suppress the Checkstyle warnings about 'AbbreviationAsWordInNameCheck':
Do you know how to do this @yegor256 ? Adding |
assign @yegor256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to chapter 2.1 in the RFC-2141, the NID can contain up to 32 characters, numbers and hyphens. With the first character not to be a hyphen: https://www.ietf.org/rfc/rfc2141.txt
I've fixed this in the URN.java class and added tests for them. I tried to fix all qulice warnings, but couldn't comply with the 'AbbreviationAsWordInNameCheck' of the URN class itself as it would break the library's compliancy.
Also some dependencies could be updated in the parents as they haven't been changed in a while.