-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prometheus/Grafana] Improve documentation in readme #156
base: master
Are you sure you want to change the base?
Conversation
@@ -40,6 +40,11 @@ Use our template to define a ServiceMonitor and to create a service account and | |||
oc process -f fuse-servicemonitor.yml -p NAMESPACE=<your-fuse-namespace> -p FUSE_SERVICE_NAME=<fuse-app-name> | oc apply -f - | |||
``` | |||
|
|||
>**NOTE:** Make sure the configuration of the created service's selector is correct and matches all conditions properly. | |||
|
|||
>**NOTE:** Fuse Console quickstart pods have no app name in labels. In the given example you have to remove *app: <app-name>* from the selector of the created service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does Fuse console quickstart mean? Can we add any link to the note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Fuse Console quickstarts" creating apps from the openshift templates rather than from the maven archetypes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tadayosi yes, we can add the link to Fuse quickstarts. Also, we can mention simply quickstarts.
@cunningt we use quickstarts from templates - https://github.com/jboss-fuse/application-templates/tree/master/quickstarts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsolovjo I think we need to refer to these as "Fuse quickstart templates" or something similar to avoid confusion : https://access.redhat.com/documentation/en-us/red_hat_fuse/7.7/html-single/fuse_on_openshift_guide/index#create-project-s2i-source-workflow
@@ -40,6 +40,11 @@ Use our template to define a ServiceMonitor and to create a service account and | |||
oc process -f fuse-servicemonitor.yml -p NAMESPACE=<your-fuse-namespace> -p FUSE_SERVICE_NAME=<fuse-app-name> | oc apply -f - | |||
``` | |||
|
|||
>**NOTE:** Make sure the configuration of the created service's selector is correct and matches all conditions properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this entail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cunningt in yaml file of a service there is a selector and in my case fuse console quickstarts didn't have app: name labels but the selector was relying on it. Therefore, the metrics weren't exposed. I added this note to check it carefully whether selector is configured correctly. Otherwise, it won't be working. Perhaps, I have to make it more clear.
@@ -40,6 +40,11 @@ Use our template to define a ServiceMonitor and to create a service account and | |||
oc process -f fuse-servicemonitor.yml -p NAMESPACE=<your-fuse-namespace> -p FUSE_SERVICE_NAME=<fuse-app-name> | oc apply -f - | |||
``` | |||
|
|||
>**NOTE:** Make sure the configuration of the created service's selector is correct and matches all conditions properly. | |||
|
|||
>**NOTE:** Fuse Console quickstart pods have no app name in labels. In the given example you have to remove *app: <app-name>* from the selector of the created service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Fuse Console quickstarts" creating apps from the openshift templates rather than from the maven archetypes?
No description provided.