Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add functionality to constrain parameters to a range #56

Merged
merged 16 commits into from
Mar 24, 2024
Merged

add functionality to constrain parameters to a range #56

merged 16 commits into from
Mar 24, 2024

Conversation

jbloom
Copy link
Member

@jbloom jbloom commented Mar 24, 2024 •
edited
Loading

  • The curve fitting parameters (top, bottom, slope) can now be constrained to a range in addition to being completely free or fixed. This can help with fitting some curves more sensibly (see this issue). Specifically:

    • fixtop and fixbottom parameters to HillCurve can be 2-tuples of bounds
    • added fixslope parameter to HillCurve and CurveFits
    • New constrain_params_range notebook tests and documents this functionality.

  • Add no_curve_fit_first argument to HillCurve to aid debugging/development.

@jbloom
HillCurve fitting w curve_fit handles bounds for fixtop and `fi…
784856a 
…xbottom`
@jbloom
make combine_curvefits pass tests now that top and bottom are floats
ce00537
@jbloom
add doc test for fitting w bounds on top and bottom
4cce883
@jbloom
HillCurve fitting with minimize_fit handles bounds for fixtop a…
ee682b4 
…nd `fixbottom`
@jbloom
start constrain_params_range notebook testing parameter constraints
de2ae04
@jbloom
implement fixslope for curve fit
9978f2d
@jbloom
implement fixslope for minimize fit
e136ebd
@jbloom
add doctests for fixslope in HillCurve
b3cd835
@jbloom
fix layout of badges in README
7374a8d
@jbloom
add fixslope to CurveFits
46978ed
@jbloom
complete constrain_params_range for docs and tests
1493143
@jbloom
update CHANGELOG
77df06e
@jbloom
lint notebooks directly w ruff rather than via nbqa
d008111
@jbloom
lint notebooks
0d3c745
@jbloom
slightly relax test to tolerate numerical error
bf409a0
@jbloom
make constrain_params_range pass tests by rounding output
35c330d
@jbloom jbloom linked an issue Mar 24, 2024 that may be closed by this pull request
Add mechanism to constrain fitting parameters #53
Closed
@jbloom jbloom merged commit 60b54ad into master Mar 24, 2024
1 check passed
@jbloom jbloom deleted the 53-constrain-params branch March 24, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mechanism to constrain fitting parameters
1 participant
@jbloom