Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 2.3.7 #76

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Prepare release 2.3.7 #76

merged 1 commit into from
Feb 8, 2022

Conversation

mcmtroffaes
Copy link
Collaborator

@mcmtroffaes mcmtroffaes commented Sep 30, 2021

@graingert Anything else needed that you can think of? Can you think of any good upstream projects or high profile users which need this package that might be interested to help testing this?

@mcmtroffaes
Copy link
Collaborator Author

Is this good to merge (conditional on #69 being merged)? I'm still waiting for a response on your py.typed related comment @graingert

@mcmtroffaes
Copy link
Collaborator Author

A heads up that I'll be merging this shortly (unless someone still wants to raise an issue).

@mcmtroffaes mcmtroffaes merged commit f5441dd into develop Feb 8, 2022
@mcmtroffaes mcmtroffaes deleted the release/2.3.7 branch February 8, 2022 12:36
@mcmtroffaes
Copy link
Collaborator Author

Will be tagging in a moment, we'll find out if the release script does it's job as intended... 🤞

@mcmtroffaes
Copy link
Collaborator Author

The release script failed:

https://github.com/jazzband/pathlib2/runs/5109176234

Not sure why. Anyway, I've done a quick manual release so it's on pypi.

@mcmtroffaes
Copy link
Collaborator Author

Just to note I've had to yank the release (and, the post release that tried to fix the problem), due to a dependency issue and python2's pip being too old to properly resolve dependencies (who knew...). I think for future pure python 3 releases we best bump the major version number for upstream projects still on python 2. I have some cleanup PR coming up which will take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants