Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial sphinx docs. #69

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Add initial sphinx docs. #69

merged 2 commits into from
Feb 3, 2022

Conversation

mcmtroffaes
Copy link
Collaborator

@mcmtroffaes mcmtroffaes commented Sep 16, 2021

See discussion in #66.

@graingert
Copy link
Member

RTD build here, I've enabled PR builds too

https://readthedocs.org/projects/pathlib2/builds/14728096/

It seems the webhook can't be installed because I don't have permission

@mcmtroffaes
Copy link
Collaborator Author

Thanks for enabling. For the webhook I guess we'll have to wait for someone who has the necessary powers here.

@mcmtroffaes
Copy link
Collaborator Author

Ready for final review.

@graingert
Copy link
Member

This looks good to me so far, but I'd like to get the readthedocs.org builtin CI/PR building before merging this in

@graingert
Copy link
Member

@jaraco can you enable the read the docs webhook for this repo?

@jezdez
Copy link
Member

jezdez commented Oct 21, 2021

@graingert I've enabled this, this should be good now.

@mcmtroffaes
Copy link
Collaborator Author

Thanks @jezdez - RTD just kicked off a build as part of #78 (failing but only because this PR hasn't been merged yet), confirming that the webhook is working now. 🎉

@jezdez
Copy link
Member

jezdez commented Oct 21, 2021

Thanks @jezdez - RTD just kicked off a build as part of #78 (failing but only because this PR hasn't been merged yet), confirming that the webhook is working now. 🎉

Awesome, I'm glad this worked out!

@graingert
Copy link
Member

Reopening to kick rtd

@graingert graingert closed this Oct 21, 2021
@graingert graingert reopened this Oct 21, 2021
@mcmtroffaes
Copy link
Collaborator Author

Reopening to kick rtd

Was just about to do the same. 😄 Looks like it's working: https://pathlib2--69.org.readthedocs.build/en/69/

@mcmtroffaes
Copy link
Collaborator Author

Is this good to merge? (@jaraco I'm still waiting to hear from you on my response to some of your comments.)

@mcmtroffaes mcmtroffaes mentioned this pull request Feb 2, 2022
@mcmtroffaes mcmtroffaes merged commit 723f636 into develop Feb 3, 2022
@mcmtroffaes mcmtroffaes deleted the feature/sphinx-docs branch February 3, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants