-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial sphinx docs. #69
Conversation
RTD build here, I've enabled PR builds too https://readthedocs.org/projects/pathlib2/builds/14728096/ It seems the webhook can't be installed because I don't have permission |
Thanks for enabling. For the webhook I guess we'll have to wait for someone who has the necessary powers here. |
9c921e3
to
ed1996c
Compare
Ready for final review. |
This looks good to me so far, but I'd like to get the readthedocs.org builtin CI/PR building before merging this in |
@jaraco can you enable the read the docs webhook for this repo? |
@graingert I've enabled this, this should be good now. |
Reopening to kick rtd |
Was just about to do the same. 😄 Looks like it's working: https://pathlib2--69.org.readthedocs.build/en/69/ |
Is this good to merge? (@jaraco I'm still waiting to hear from you on my response to some of your comments.) |
See discussion in #66.