-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the simple diffusion model tutorial #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all - left a few comments, some typos and a few suggestions.
I also included a suggestion for a sections/subsections hierarchy that I think makes the flow of the tutorial better. Cheers!
I believe adding the .md file to Line 32 in 977d5c4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! A few little book-keeping things:
- You'll need to ensure the ipynb and markdown are linked via jupytext. See https://jax-ai-stack.readthedocs.io/en/latest/contributing.html#adding-a-new-notebook for details.
- To make the new tutorial render as part of the documentation, you need to add it to the table of contents in https://github.com/jax-ml/jax-ai-stack/blob/main/docs/tutorials.md
- You'll need to add the markdown file here to avoid a build failure:
Line 32 in 0392327
exclude_patterns = [ - You'll probably need to add the notebook to the exclude patterns unless you want the doc build to attempt notebook execution:
Line 63 in 0392327
nb_execution_excludepatterns = [
Once those are addressed, we'll be able to see this as part of a build, which should make it easier to review. Thanks!
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
…ithin exclude_patterns[]
Including a simple diffusion model development and training tutorial.