Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the simple diffusion model tutorial #83

Merged
merged 22 commits into from
Nov 14, 2024
Merged

Conversation

lucianommartins
Copy link
Contributor

Including a simple diffusion model development and training tutorial.

Copy link
Contributor

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all - left a few comments, some typos and a few suggestions.

I also included a suggestion for a sections/subsections hierarchy that I think makes the flow of the tutorial better. Cheers!

docs/digits_diffusion_model.md Outdated Show resolved Hide resolved
docs/digits_diffusion_model.md Outdated Show resolved Hide resolved
docs/digits_diffusion_model.md Outdated Show resolved Hide resolved
docs/digits_diffusion_model.md Outdated Show resolved Hide resolved
docs/digits_diffusion_model.md Outdated Show resolved Hide resolved
docs/digits_diffusion_model.md Outdated Show resolved Hide resolved
docs/digits_diffusion_model.md Show resolved Hide resolved
docs/digits_diffusion_model.md Outdated Show resolved Hide resolved
docs/digits_diffusion_model.md Show resolved Hide resolved
docs/digits_diffusion_model.md Outdated Show resolved Hide resolved
@melissawm
Copy link
Contributor

I believe adding the .md file to

exclude_patterns = [
will fix the Read the Docs build.

Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! A few little book-keeping things:

Once those are addressed, we'll be able to see this as part of a build, which should make it easier to review. Thanks!

@jakevdp jakevdp self-assigned this Nov 4, 2024
lucianommartins and others added 16 commits November 12, 2024 16:28
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
@jakevdp jakevdp merged commit 0197a4b into jax-ml:main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants