Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tutorial for data loaders on gpu with jax #109

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

selamw1
Copy link
Contributor

@selamw1 selamw1 commented Nov 21, 2024

Adding Introduction to Data Loaders on GPU with JAX.

@selamw1
Copy link
Contributor Author

selamw1 commented Nov 22, 2024

Headings adjusted and new overview paragraph added into the introduction.

@trallard
Copy link
Contributor

@selamw1 there seem to be a couple of merge conflicts here would you be able to fix them, please?

@selamw1
Copy link
Contributor Author

selamw1 commented Nov 26, 2024

File conflict resolved.

@jakevdp
Copy link
Collaborator

jakevdp commented Dec 2, 2024

I see the new introductory paragraph – thanks for adding that!

I'm still somewhat concerned here about duplication between the three "data loader" tutorials: one for CPU, one for GPU, and one for TPU. Putting myself in the shoes of a reader trying to become familiar with JAX, it's hard to know without reading each in detail what the key differences are, or why I should care.

Maybe we could work on de-duplicating the three tutorials, so that they build on each other sequentially rather than repeating the same concepts three times with slight differences?

@selamw1
Copy link
Contributor Author

selamw1 commented Dec 3, 2024

I see the new introductory paragraph – thanks for adding that!

I'm still somewhat concerned here about duplication between the three "data loader" tutorials: one for CPU, one for GPU, and one for TPU. Putting myself in the shoes of a reader trying to become familiar with JAX, it's hard to know without reading each in detail what the key differences are, or why I should care.

Maybe we could work on de-duplicating the three tutorials, so that they build on each other sequentially rather than repeating the same concepts three times with slight differences?

The notebooks have been adjusted to highlight the key differences between each other, and their respective references have been added to make them standalone tutorials.

@jakevdp
Copy link
Collaborator

jakevdp commented Dec 4, 2024

Thanks - we'll have to rebase this PR to reflect the fact that docs has moved to docs/source.

@selamw1
Copy link
Contributor Author

selamw1 commented Dec 4, 2024

Rebase has been done to move files from docs to docs/source.

@jakevdp
Copy link
Collaborator

jakevdp commented Dec 4, 2024

Thanks - it looks like we ended up with two copies of each file, one in docs/ and one in docs/source/. Can you remove the ones in docs/? Thanks!

@@ -19,11 +19,13 @@ JAX_basic_text_classification
JAX_examples_image_segmentation
JAX_Vision_transformer
JAX_machine_translation
<<<<<<< HEAD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray git conflict marker; we need to remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@selamw1
Copy link
Contributor Author

selamw1 commented Dec 4, 2024

Thanks - it looks like we ended up with two copies of each file, one in docs/ and one in docs/source/. Can you remove the ones in docs/? Thanks!

Yes, its done.

Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakevdp jakevdp merged commit 67a7c94 into jax-ml:main Dec 4, 2024
6 checks passed
selamw1 added a commit to selamw1/jax-ai-stack that referenced this pull request Dec 5, 2024
selamw1 added a commit to selamw1/jax-ai-stack that referenced this pull request Dec 5, 2024
windmaple pushed a commit to windmaple/jax-ai-stack that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants