-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tutorial for data loaders on gpu with jax #109
Conversation
Headings adjusted and new overview paragraph added into the introduction. |
@selamw1 there seem to be a couple of merge conflicts here would you be able to fix them, please? |
bc69d41
to
4144201
Compare
File conflict resolved. |
I see the new introductory paragraph – thanks for adding that! I'm still somewhat concerned here about duplication between the three "data loader" tutorials: one for CPU, one for GPU, and one for TPU. Putting myself in the shoes of a reader trying to become familiar with JAX, it's hard to know without reading each in detail what the key differences are, or why I should care. Maybe we could work on de-duplicating the three tutorials, so that they build on each other sequentially rather than repeating the same concepts three times with slight differences? |
95f4333
to
f97b3d9
Compare
The notebooks have been adjusted to highlight the key differences between each other, and their respective references have been added to make them standalone tutorials. |
Thanks - we'll have to rebase this PR to reflect the fact that |
f97b3d9
to
53701d4
Compare
Rebase has been done to move files from |
Thanks - it looks like we ended up with two copies of each file, one in |
docs/source/tutorials.md
Outdated
@@ -19,11 +19,13 @@ JAX_basic_text_classification | |||
JAX_examples_image_segmentation | |||
JAX_Vision_transformer | |||
JAX_machine_translation | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray git conflict marker; we need to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Yes, its done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adding Introduction to Data Loaders on GPU with JAX.