Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change documentation theme #101

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Change documentation theme #101

merged 2 commits into from
Nov 19, 2024

Conversation

pavithraes
Copy link
Contributor

@pavithraes pavithraes commented Nov 19, 2024

This PR introduces sphinx_book_theme, similar to the JAX documentation. Also adds sphinx-copybutton extension.

Preview link: https://jax-ai-stack--101.org.readthedocs.build/en/101/

Note for reviewers: Please also try a local docs build. I was running into intermittent sphinx warnings ("file too long" and "...ipynb :document isn't included in any toctree"). I'm fairly certain those were local env/cache issues, but will be good to verify.

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Copy link
Contributor

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see that warning about file name too long when running with sphinx-build -b docs/ docs/_build/html but
Running with:

sphinx-build -b html docs docs/build/html -j auto

#or
sphinx-build -b html -D nb_execution_mode=off docs docs/build/html -j auto

did not result in that warning and the built docs look all good so it seemed there was some odd recursive creation of the html files happening

Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
@jakevdp jakevdp merged commit 423d713 into jax-ml:main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants