Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a delay to fix race #279

Merged
merged 1 commit into from
Jan 3, 2024
Merged

adding a delay to fix race #279

merged 1 commit into from
Jan 3, 2024

Conversation

xgdgsc
Copy link
Contributor

@xgdgsc xgdgsc commented Dec 10, 2023

Pull Request Description

fix #277 . I tested locally it fixes the issue for me.

Changes Proposed

  • adding a delay before modify file

Related Issues

fix #277

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Dec 11, 2023

It doesn' t work on another computer. Someone mentioned at SilentVoid13/Templater#924 (comment) using vault.process instead might work?

@valentine195 valentine195 merged commit b8e5ed4 into javalent:main Jan 3, 2024
valentine195 added a commit that referenced this pull request Jan 3, 2024
@valentine195
Copy link
Member

It doesn' t work on another computer. Someone mentioned at SilentVoid13/Templater#924 (comment) using vault.process instead might work?

Damn, I just saw this. Oh well. I'll investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Using multiple dice-mod rolls in one template causes errors
2 participants