fix: reduced margin on content inside admonitions without titles (close

#185)
javalent · Feb 18, 2022 · 643ca8e · 643ca8e
1 parent 7034477
commit 643ca8e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/src/assets/main.css b/src/assets/main.css
@@ -61,9 +61,10 @@
     display: none;
 }
 
-.admonition > .admonition-title.no-title + .admonition-content-holder {
-    margin-top: 1rem;
-    margin-bottom: 1rem;
+.admonition-plugin.no-title .admonition-content-holder,
+.admonition-plugin.no-title .admonition-content-holder > .admonition-content {
+    margin-top: 0;
+    margin-bottom: 0;
 }
 
 .admonition-content-holder {

diff --git a/src/main.ts b/src/main.ts
@@ -931,7 +931,7 @@ ${editor.getDoc().getSelection()}
                 if (checking) return admonition.command;
                 if (admonition.command) {
                     try {
-                        const title = admonition.title ?? ""
+                        const title = admonition.title ?? "";
                         editor.getDoc().replaceSelection(
                             `\`\`\`ad-${admonition.type}
 title: ${title}
@@ -1269,7 +1269,9 @@ ${editor.getDoc().getSelection()}\n--- admonition\n`
                 attrs.open = "open";
             }
             admonition = createEl("details", {
-                cls: `admonition admonition-${type} admonition-plugin`,
+                cls: `admonition admonition-${type} admonition-plugin ${
+                    !title?.trim().length ? "no-title" : ""
+                }`,
                 attr: attrs
             });
             titleEl = admonition.createEl("summary", {
@@ -1279,7 +1281,9 @@ ${editor.getDoc().getSelection()}\n--- admonition\n`
             });
         } else {
             admonition = createDiv({
-                cls: `admonition admonition-${type} admonition-plugin`,
+                cls: `admonition admonition-${type} admonition-plugin ${
+                    !title?.trim().length ? "no-title" : ""
+                }`,
                 attr: attrs
             });
             titleEl = admonition.createDiv({
@@ -1391,7 +1395,9 @@ ${editor.getDoc().getSelection()}\n--- admonition\n`
                 attrs.open = "open";
             }
             admonition = createEl("details", {
-                cls: `admonition admonition-${type} admonition-plugin admonition-plugin-async`,
+                cls: `admonition admonition-${type} admonition-plugin admonition-plugin-async ${
+                    !title?.trim().length ? "no-title" : ""
+                }`,
                 attr: attrs
             });
             titleEl = admonition.createEl("summary", {
@@ -1401,7 +1407,9 @@ ${editor.getDoc().getSelection()}\n--- admonition\n`
             });
         } else {
             admonition = createDiv({
-                cls: `admonition admonition-${type} admonition-plugin`,
+                cls: `admonition admonition-${type} admonition-plugin ${
+                    !title?.trim().length ? "no-title" : ""
+                }`,
                 attr: attrs
             });
             titleEl = admonition.createDiv({