feat(transient): adds conj!, assoc!, dissoc! and pop! for transients

[Samy-33]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 89.90536% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 59.54%. Comparing base (c41ff94) to head (8ab39ce).
Report is 19 commits behind head on transient.

❗ Current head 8ab39ce differs from pull request most recent head b25c901. Consider uploading reports for the commit b25c901 to get more accurate results

Files	Patch %	Lines
src/cpp/jank/util/escape.cpp	71.92%	16 Missing ⚠️
src/cpp/jank/runtime/obj/transient_vector.cpp	0.00%	5 Missing ⚠️
src/cpp/jank/analyze/processor.cpp	85.18%	4 Missing ⚠️
src/cpp/jank/read/parse.cpp	92.59%	4 Missing ⚠️
src/cpp/jank/runtime/obj/transient_hash_map.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           transient      #62      +/-   ##
=============================================
- Coverage      61.29%   59.54%   -1.75%     
=============================================
  Files             52       55       +3     
  Lines           7926     7655     -271     
=============================================
- Hits            4858     4558     -300     
- Misses          3068     3097      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jeaye]

Looks like these were changed from [&] to [=], but I think they can be []. Did you hit an issue with that?

[Samy-33]

Yes, the compiler's mad at me:

➜  jank git:(transient-vector-fns) ✗ ./bin/compile
[1/1] Generating classes/core-libraries
input_line_94:18:29: error: variable 'call_574' cannot be implicitly captured in a lambda with no capture-default specified
                    { throw call_574; }
                            ^
input_line_94:9:243: note: 'call_574' declared here
        jank::profile::timer __timer{ "dissoc_BANG__558" };auto const map_575(jank::make_box<jank::runtime::obj::persistent_array_map>(jank::runtime::detail::in_place_unique{}, jank::make_array_box<object_ptr>(const_561, coll),2));auto const call_574(jank::runtime::dynamic_call(ex_info_559->deref(), const_560, map_575));object_ptr native_573{ obj::nil::nil_const() };{ object_ptr __value{ obj::nil::nil_const() };__value = visit_object
                                                                                                                                                                                                                                                  ^
input_line_94:11:19: note: lambda expression begins here
                  [](auto const typed_t, auto const key) -> object_ptr
                  ^
input_line_94:11:20: note: capture 'call_574' by value
                  [](auto const typed_t, auto const key) -> object_ptr
                   ^
                   call_574

[jeaye]

Ah, that's because you're throwing coll instead of typed_coll. Since you have the fully typed version as the first param to the lambda, we can use that rather than also capturing the erased version.