Implement 9 of 21 clojure.string vars #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool! If you start looking at regex, I started some of that work here. I'm still looking through various performance characteristic of different regex libraries. |
djblue
reviewed
Jan 29, 2025
jeaye
requested changes
Feb 5, 2025
| @@ -0,0 +1,55 @@ | |||
| (ns clojure-string.self-test | |||
There was a problem hiding this comment.
Please put these tests in the https://github.com/jank-lang/clojure-test repo instead. We should have one place for testing all of the official Clojure namespaces.
There was a problem hiding this comment.
| #include <jank/runtime/core.hpp> | ||
| #include <jank/runtime/context.hpp> | ||
| #include <jank/runtime/behavior/callable.hpp> | ||
| #include <jank/runtime/visit.hpp> |
There was a problem hiding this comment.
You're not using any visting fns, while this is an incredibly expensive include. Please audit all of the includes here to ensure they're needed.
There was a problem hiding this comment.
Still working on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
clojure.string/blank?clojure.string/capitalizeclojure.string/ends-with?clojure.string/escapeclojure.string/includes?clojure.string/lower-caseclojure.string/reverseclojure.string/starts-with?clojure.string/upper-case