chore: universal module definition #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freelerobot
reviewed
Dec 8, 2023
|
|
||
| declare global { | ||
| interface Window { | ||
| core?: any; | ||
| namespace NodeJS { |
There was a problem hiding this comment.
Yes, good. I was thinking the same. The modules we're wrapping & exposing via core are particular to "Node native modules". So this namespace makes a lot more sense to external devs.
namchuai
reviewed
Dec 8, 2023
| @@ -218,7 +218,7 @@ export interface Model { | |||
| * Default: "to_download" | |||
| * Enum: "to_download" "downloading" "ready" "running" | |||
| */ | |||
| state: ModelState; | |||
| state?: ModelState; | |||
There was a problem hiding this comment.
one of my concern is Rex's model.json does not provide us default state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the core module UMD-compatible for use on both browser and Node.js platforms. The core should not have knowledge of the window object, which is specific to browsers; it should be a universal module.
This is the first step of sharing modules between our server and extensions.