fix: remote engine model auto select #4609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes updates to the
RemoteEngineSettings.tsx
file to enhance functionality and improve state management by adding new atom values and setters from thejotai
library. The most important changes include importing additional atoms, setting the selected model atom based on conditions, and using thethreadsAtom
to manage thread-related data.Enhancements to state management:
web/screens/Settings/Engines/RemoteEngineSettings.tsx
: AddeduseSetAtom
fromjotai
to manage state updates.web/screens/Settings/Engines/RemoteEngineSettings.tsx
: ImportedselectedModelAtom
andthreadsAtom
fromModel.atom
andThread.atom
respectively to handle selected model and thread-related states.Functional improvements:
web/screens/Settings/Engines/RemoteEngineSettings.tsx
: IntroducedsetSelectedModel
to set the selected model atom.web/screens/Settings/Engines/RemoteEngineSettings.tsx
: UpdateduseEffect
to set the selected model to the first remote model if no threads are present.Fixes Issues
Screen.Recording.2025-02-07.at.23.35.03.mov
Screen.Recording.2025-02-07.at.23.34.24.mov
Self Checklist