Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server log actions position #4608

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Feb 7, 2025

Issue

CleanShot 2025-02-07 at 22 31 39
Screenshot 2025-02-07 at 22 58 34

Describe Your Changes

This pull request includes several changes to the ServerLogs component in the web/containers/ServerLogs/index.tsx file, as well as some cleanup in the LoadModelError component in the web/screens/Thread/ThreadCenterPanel/LoadModelError/index.tsx file. The main changes involve restructuring the layout and improving the readability of the ServerLogs component, and removing unused imports and code in the LoadModelError component.

Changes to ServerLogs component:

  • Moved the ScrollArea component inside a new div to improve layout structure. [1] [2]
  • Adjusted the conditional class name for the empty state to add more margin when withCopy is true.
  • Fixed the formatting of the "Empty logs" message to improve readability.

Cleanup in LoadModelError component:

  • Removed unused imports and the setModalTroubleShooting function to clean up the code. [1] [2]

Fixes Issues

CleanShot 2025-02-07 at 22 52 47

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Feb 7, 2025
@urmauur urmauur added this to the v0.5.15 milestone Feb 7, 2025
@urmauur urmauur requested a review from louis-menlo February 7, 2025 15:58
@urmauur urmauur self-assigned this Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Barecheck - Code coverage report

Total: 67.74%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
web/containers/ServerLogs/index.tsx21-27, 29, 31-34, 42-44, 48-49, 52-53, 57, 60, 62, 64-65, 67-68, 70-72, 74-75, 79-81, 83, 86-89, 104, 117, 150
web/screens/Thread/ThreadCenterPanel/LoadModelError/index.tsx15-18, 33-35, 38

@urmauur urmauur requested a review from imtuyethan February 7, 2025 16:43
Copy link
Contributor

github-actions bot commented Feb 8, 2025

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit a9a63ab into release/v0.5.15 Feb 9, 2025
21 checks passed
@urmauur urmauur deleted the fix/log-action-position branch February 9, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants