Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load model error component #4604

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Feb 7, 2025

Issue

Screenshot 2025-02-07 at 15 28 26

Describe Your Changes

This pull request includes changes to improve error handling and component reuse in the ErrorMessage and LoadModelError components. The most important changes include making the ErrorMessage component more flexible by adding optional props, updating references to the message object to handle undefined values safely, and integrating the ErrorMessage component into the LoadModelError component.

Improvements to ErrorMessage component:

Integration of ErrorMessage into LoadModelError:

Fixes Issues

CleanShot 2025-02-07 at 15 26 21

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Feb 7, 2025
@urmauur urmauur added this to the v0.5.15 milestone Feb 7, 2025
@urmauur urmauur requested a review from louis-menlo February 7, 2025 08:29
@urmauur urmauur self-assigned this Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Barecheck - Code coverage report

Total: 67.73%

Your code coverage diff: 0.05% ▴

Uncovered files and lines
FileLines
web/containers/ErrorMessage/index.tsx46-51, 69-70
web/screens/Thread/ThreadCenterPanel/LoadModelError/index.tsx18-22, 37-39, 42

@urmauur urmauur merged commit 9837d09 into release/v0.5.15 Feb 7, 2025
9 checks passed
@urmauur urmauur deleted the fix/load-model-error branch February 7, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant