Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: adjust hub ui in different themes #4574

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Feb 4, 2025

Describe Your Changes

This pull request includes a series of updates to the styles and components in the project. The changes primarily focus on improving the visual consistency and theming across various components by using CSS variables.

Style Improvements:

  • Updated border-color and background-color properties to use the hsla(var(--app-border)) and hsla(var(--app-bg)) variables for better theming in Dropdown styles. [1] [2]
  • Modified the Dropdown component in ModelHeader to include additional styling properties like max-h, max-w, and overflow-y for better layout control.

Component Updates:

  • Removed the hardcoded text-black class from table cells in ModelPage to ensure text color is controlled by the theme. [1] [2]
  • Updated the HubScreen component to use CSS variables for border and background colors, enhancing the visual consistency.

General CSS Adjustments:

  • Changed the color property in marked.scss to use the hsla(var(--text-primary)) variable for primary text color.
  • Adjusted the pre element styles in marked.scss by modifying the border-radius and removing the hardcoded background color.
  • Updated table header and horizontal rule styles in marked.scss to use CSS variables for background and border colors. [1] [2]

Fixes Issues

CleanShot 2025-02-04 at 20 56 59
CleanShot 2025-02-04 at 20 56 56
CleanShot 2025-02-04 at 20 55 07
CleanShot 2025-02-04 at 20 56 53
CleanShot 2025-02-04 at 20 56 49
CleanShot 2025-02-04 at 20 55 21
CleanShot 2025-02-04 at 20 55 17
CleanShot 2025-02-04 at 20 55 12

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: enhancement Improves a current feature label Feb 4, 2025
@urmauur urmauur added this to the v0.5.16 milestone Feb 4, 2025
@urmauur urmauur requested a review from louis-menlo February 4, 2025 13:59
@urmauur urmauur self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Barecheck - Code coverage report

Total: 67.61%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE ITTTTT

@urmauur urmauur merged commit 2d82567 into dev Feb 4, 2025
17 checks passed
@urmauur urmauur deleted the enhancement/hub-ui branch February 4, 2025 14:24
@github-actions github-actions bot modified the milestones: v0.5.16, v0.5.15 Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@imtuyethan imtuyethan modified the milestones: v0.5.15, v0.5.16 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improves a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: New Jan Hub UI
3 participants