enhancement: code snippet colors should depend on native theme #4566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes several changes to the theme configurations and styles for code blocks, as well as updates to the
MarkdownTextMessage
component to improve consistency and appearance.Theme Configuration Updates:
code-block
color definition from multiple theme files, includingdark-dimmed
,joi-dark
,joi-light
, andnight-blue
(themes/dark-dimmed/theme.json
[1]themes/joi-dark/theme.json
[2]themes/joi-light/theme.json
[3]themes/night-blue/theme.json
[4].Component Style Updates:
MarkdownTextMessage
component to usehsla(var(--app-code-block))
andhsla(var(--text-primary))
for better theme consistency (web/screens/Thread/ThreadCenterPanel/TextMessage/MarkdownTextMessage.tsx
[1] [2] [3] [4].Code Block Style Improvements:
!important
to various color definitions incode-block.scss
to ensure they are applied correctly (web/styles/components/code-block.scss
[1] [2] [3] [4] [5].code-block.scss
(web/styles/components/code-block.scss
web/styles/components/code-block.scssL162-R171).Main Style Updates:
app-code-block
and various highlight colors inmain.scss
(web/styles/main.scss
[1] [2].Fixes Issues
Self Checklist