Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pull models list when setting up a new remote engine #4547

Merged

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented Jan 30, 2025

Describe Your Changes

Previously, when setting up a new remote provider, users had to manually set up models. With this update, as soon as users set up a new provider, it will automatically attempt to pull models from the specified /models endpoint.

CleanShot 2025-01-30 at 15 15 11

Fixes Issues

Self Checklist

This pull request includes several changes to the JSONEngineManagementExtension class and related configuration files to enhance the handling of remote models and engines. The most important changes include modifying the Model type, updating the configuration, and improving the methods for adding and populating remote models.

Changes to Model type:

Configuration updates:

Enhancements to JSONEngineManagementExtension class:

Copy link
Contributor

Barecheck - Code coverage report

Total: 67.86%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@louis-menlo louis-menlo requested a review from a team January 30, 2025 09:04
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-menlo louis-menlo merged commit 33db513 into release/v0.5.15 Jan 30, 2025
22 checks passed
@louis-menlo louis-menlo deleted the feat/auto-pull-models-from-remote-provider branch January 30, 2025 10:26
@github-actions github-actions bot added this to the v0.5.15 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants