Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix remote engines request templates #4477

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented Jan 17, 2025

Describe Your Changes

This PR is to correct remote engine request templates and model settings

  • Anthropic models do not work with non-stream setting
  • Mistral, martian, nvidia, openrouter models do not have parameters configured

Self Checklist

This pull request includes several changes to the extensions/engine-management-extension models and resources, as well as a minor update to the web/utils/messageRequestBuilder.ts file. The most important changes involve renaming a key in multiple model JSON files and simplifying JSON templates in resource files.

Key renaming in model JSON files:

Simplification of JSON templates in resource files:

Minor update in TypeScript file:

@github-actions github-actions bot added the type: chore Maintenance, operational label Jan 17, 2025
Copy link
Contributor

Barecheck - Code coverage report

Total: 67.98%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/utils/messageRequestBuilder.ts37-38, 50-53, 55, 62, 67-68, 75, 80, 95-96, 101, 117-118, 122-123, 128, 131, 137-141, 143, 145, 147, 155, 158, 162

@louis-menlo louis-menlo merged commit f0bd239 into main Jan 17, 2025
15 of 16 checks passed
@louis-menlo louis-menlo deleted the fix/remote-engine-request-templates branch January 17, 2025 06:35
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 17, 2025
@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants