Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect default max_tokens set - legacy issue #4451

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

  • This PR fixes an issue where the app resets the default max_tokens to 8192, even if model settings specify a smaller number.

CleanShot 2025-01-15 at 10 38 27@2x

Fixes Issues

Self Checklist

This pull request includes a small but important change to the ModelDropdown component in the web/containers/ModelDropdown/index.tsx file. The change involves updating the property name used to determine the maximum number of tokens allowed.

@louis-menlo louis-menlo requested a review from urmauur January 15, 2025 03:40
@github-actions github-actions bot added the type: bug Something isn't working label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Barecheck - Code coverage report

Total: 69.26%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/containers/ModelDropdown/index.tsx126-127, 137, 150, 152, 154-155, 157-158, 160-163, 165, 187-188, 208-209, 216-219, 221, 223, 242, 247, 257, 264, 267-268, 289, 313, 336, 357, 366, 372, 385, 389, 391-396, 399, 402, 459-460, 462, 488, 496, 498, 523, 528-529, 531, 535-537, 539-540, 542, 552-555, 586, 594, 596

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-menlo louis-menlo merged commit 58bb1b4 into dev Jan 15, 2025
19 checks passed
@louis-menlo louis-menlo deleted the fix/incorrect_default_max_tokens branch January 15, 2025 05:37
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 15, 2025
@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: [0.5.12] max_tokens automatically revert back to 8192 when users create a new thread
3 participants