-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge bug fixes from 0.5.12 into dev #4338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release cut 0.5.12
fix: thread error handling
* fix: threads and messages are cutoff * fix: threads sorting * chore: bump cortex latest release and app version
* fix: cleaning a thread should just clear out messages * chore: clean up
* fix: scroll bottom when generation text * chore: update logic when prepare generate * chore: fix case no switch thread * chore: remore dep thread id * chore: handle fix generation without have dep thread id
* fix: disabled native resize textarea when textarea autogrowing * fix: disabled auto resize on instruction field
urmauur
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Changes made
This pull request includes several changes to improve the functionality and performance of the conversational extension, update model handling, and enhance the user interface. The most important changes include modifications to API calls, the addition of new models, and updates to state management.
API Call Improvements:
extensions/conversational-extension/src/index.ts
: Updated API calls inlistThreads
,listMessages
,getThreadAssistant
, andhealthz
methods to include alimit=-1
parameter for fetching all records. [1] [2] [3] [4]extensions/model-extension/src/cortex.ts
: Modified thegetModels
method to include alimit=-1
parameter.Model Handling Enhancements:
extensions/inference-openai-extension/resources/models.json
: Added new modelsgpt-4o-mini
ando1
with their respective configurations.web/hooks/useCreateNewThread.ts
: Refactored thread creation logic and updated metadata handling. [1] [2] [3]State Management Updates:
web/helpers/atoms/ChatMessage.atom.ts
: IntroducedsubscribedGeneratingMessageAtom
to store subscribed generating message threads. [1] [2]web/helpers/atoms/Thread.atom.ts
: AddedcreateNewThreadAtom
for creating new threads and updated thread sorting logic. [1] [2]UI and UX Improvements:
joi/src/core/TextArea/index.tsx
: EnhancedTextArea
component to supportautoResize
functionality.web/containers/ModelDropdown/index.tsx
: Simplified the logic for setting the selected model and updated placeholder text. [1] [2]Test Adjustments:
web/hooks/useDeleteThread.test.ts
: Updated tests to reflect changes in thread deletion logic and added checks for message deletion and thread modification. [1] [2]