From f5fc7451f9ae3e23c178a4a2bad66972a2a90491 Mon Sep 17 00:00:00 2001 From: James Nord Date: Wed, 19 Feb 2025 16:29:26 +0000 Subject: [PATCH 1/2] remove tasklists TaskLists are EOL per https://github.blog/changelog/2025-02-18-github-issues-projects-february-18th-update/#tasklist-blocks-will-be-retired-and-replaced-with-sub-issues --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c937a5df6469..a56fa75bfcc7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -80,7 +80,6 @@ Leave the proposed upgrade guidelines in the pull request with the "N/A" value i The changelog generator relies on the presence of the upgrade guidelines section as part of its data extraction process. --> -```[tasklist] ### Submitter checklist - [ ] The Jira issue, if it exists, is well-described. - [ ] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade. @@ -90,7 +89,7 @@ The changelog generator relies on the presence of the upgrade guidelines section - [ ] New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)). - [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials. - [ ] For new APIs and extension points, there is a link to at least one consumer. -``` + ### Desired reviewers @@ -102,7 +101,7 @@ If you need an accelerated review process by the community (e.g., for critical b Before the changes are marked as `ready-for-merge`: -```[tasklist] + ### Maintainer checklist - [ ] There are at least two (2) approvals for the pull request and no outstanding requests for change. - [ ] Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change. @@ -110,4 +109,3 @@ Before the changes are marked as `ready-for-merge`: - [ ] Proper changelog labels are set so that the changelog can be generated automatically. - [ ] If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)). - [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)). -``` From 3a679b71326c0a3574967c14db50cbc22ce9834b Mon Sep 17 00:00:00 2001 From: Kris Stern Date: Thu, 20 Feb 2025 01:59:05 +0800 Subject: [PATCH 2/2] fixup: apply prettier fix --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a56fa75bfcc7..3071a40497aa 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -81,6 +81,7 @@ The changelog generator relies on the presence of the upgrade guidelines section --> ### Submitter checklist + - [ ] The Jira issue, if it exists, is well-described. - [ ] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade. - [ ] There is automated testing or an explanation as to why this change has no tests. @@ -90,7 +91,6 @@ The changelog generator relies on the presence of the upgrade guidelines section - [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials. - [ ] For new APIs and extension points, there is a link to at least one consumer. - ### Desired reviewers @mention @@ -101,8 +101,8 @@ If you need an accelerated review process by the community (e.g., for critical b Before the changes are marked as `ready-for-merge`: - ### Maintainer checklist + - [ ] There are at least two (2) approvals for the pull request and no outstanding requests for change. - [ ] Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change. - [ ] Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.