Delete temporary file on close #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR. Looks like the tests are failing but I think for an unrelated reason... I'm happy to have a look at this issue and review the PR, but probably won't be for a few days. Or feel free to have a look if you want to fixup the tests. |
ivanwick
force-pushed
the
issue-262-delete-temp-file-on-close
branch
from
060a71b to
c314b27
Compare
A temp file is created when reading an HdfFile from an InputStream. Delete the temp file when the HdfFile is closed, or at application exit if the HdfFile was never closed. Fixes jamesmudd#262
ivanwick
force-pushed
the
issue-262-delete-temp-file-on-close
branch
from
c314b27 to
337b831
Compare
|
There were a couple of checkstyle violations that are fixed in the latest push by not using the '.*' form of import, and adding the standard header to a new file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temp file is created when reading an HdfFile from an InputStream. Delete the temp file when the HdfFile is closed, or at application exit if the HdfFile was never closed.
Fixes #262