Cleanup

jamesmudd · Aug 8, 2024 · b16ff43 · b16ff43
1 parent 895e5ec
commit b16ff43
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/jhdf/src/main/java/io/jhdf/api/WritableAttributeImpl.java b/jhdf/src/main/java/io/jhdf/api/WritableAttributeImpl.java
@@ -9,7 +9,6 @@
  */
 package io.jhdf.api;
 
-import io.jhdf.Utils;
 import io.jhdf.object.datatype.DataType;
 import io.jhdf.object.message.DataSpace;
 

diff --git a/jhdf/src/main/java/io/jhdf/object/datatype/DataType.java b/jhdf/src/main/java/io/jhdf/object/datatype/DataType.java
@@ -110,7 +110,7 @@ public static DataType fromObject(Object data) {
 		} else if (type == double.class || type == Double.class) {
 			return FloatingPoint.DOUBLE;
 		} else if (type == String.class) {
-			return StringData.create(data); // TODO
+			return StringData.create(data);
 		} else {
 			throw new HdfException("Could not create DataType for: " + type);
 		}

diff --git a/jhdf/src/test/java/io/jhdf/writing/StringWritingTest.java b/jhdf/src/test/java/io/jhdf/writing/StringWritingTest.java
@@ -106,6 +106,10 @@ void writeStrings() throws Exception {
 			Map<String, Node> datasets = hdfFile.getChildren();
 			assertThat(datasets).hasSize(4);
 
+			String[] proseReadBackArray = (String[]) hdfFile.getDatasetByPath("prose").getData();
+			String proseReadback = StringUtils.joinWith(" ", proseReadBackArray);
+			assertThat(proseReadback).isEqualTo(prose);
+
 			// Just check thw whole file is readable
 			TestAllFilesBase.verifyAttributes(hdfFile);
 			TestAllFilesBase.recurseGroup(hdfFile);