Fix pushing a value to an array without schema

jagi · Oct 18, 2015 · 7e43b94 · 7e43b94
1 parent 398b263
commit 7e43b94
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/lib/modules/fields/pop.js b/lib/modules/fields/pop.js
@@ -143,11 +143,11 @@ proto._popOne = function(fieldName, popValue, options) {
   Class.emitEvent(event);
 };
 
-proto._popMany = function(fieldsValues, options) {
+proto._popMany = function(popValues, options) {
   var doc = this;
 
   // Set multiple fields.
-  _.each(fieldsValues, function(popValue, fieldName) {
+  _.each(popValues, function(popValue, fieldName) {
     doc._popOne(fieldName, popValue, options);
   });
 };

diff --git a/lib/modules/fields/pull.js b/lib/modules/fields/pull.js
@@ -96,7 +96,7 @@ proto._pullOne = function(fieldName, pullValue, options) {
       // Add modifier.
       if (options.modifier) {
         if (_.isUndefined(modifierPulledValue)) {
-          modifierPulledValue = EJSON.clone(fieldValue);
+          modifierPulledValue = EJSON.clone(pullValue);
         }
         if (nestedDoc instanceof Astro.BaseClass) {
           if (_.isUndefined(index)) {
@@ -154,11 +154,11 @@ proto._pullOne = function(fieldName, pullValue, options) {
   Class.emitEvent(event);
 };
 
-proto._pullMany = function(fieldsValues, options) {
+proto._pullMany = function(pullValues, options) {
   var doc = this;
 
   // Pull multiple values.
-  _.each(fieldsValues, function(pullValue, fieldName) {
+  _.each(pullValues, function(pullValue, fieldName) {
     doc._pullOne(fieldName, pullValue, options);
   });
 };

diff --git a/lib/modules/fields/push.js b/lib/modules/fields/push.js
@@ -97,7 +97,7 @@ proto._pushOne = function(fieldName, pushValue, options) {
       // Add modifier.
       if (options.modifier) {
         if (_.isUndefined(modifierPushedValue)) {
-          modifierPushedValue = EJSON.clone(fieldValue);
+          modifierPushedValue = EJSON.clone(pushValue);
         }
         if (nestedDoc instanceof Astro.BaseClass) {
           if (_.isUndefined(index)) {
@@ -153,12 +153,12 @@ proto._pushOne = function(fieldName, pushValue, options) {
   Class.emitEvent(event);
 };
 
-proto._pushMany = function(fieldsValues, options) {
+proto._pushMany = function(pushValues, options) {
   var doc = this;
 
   // Set multiple fields.
-  _.each(fieldsValues, function(fieldValue, fieldName) {
-    doc._pushOne(fieldName, fieldValue, options);
+  _.each(pushValues, function(pushValue, fieldName) {
+    doc._pushOne(fieldName, pushValue, options);
   });
 };