[fix] Update es-index-cleaner to delete indices based on current time

[Asatyam]

Which problem is this PR solving?

• Resolves [Bug]: Index cleaner only works once a day, even if it runs every hour. #6236

Description of the changes

• Changes the es-index-cleaner to remove indices older than 24 hours from the time it runs, so deletions happen hourly instead of just at midnight.

How was this change tested?

• CI

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: npm run lint and npm run test

[gemini-code-assist]

Hello @Asatyam, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue #6236 by modifying the es-index-cleaner tool to delete indices based on the current time instead of calculating from tomorrow's midnight. The change involves updating the time calculation logic in cmd/es-index-cleaner/main.go to use time.Now().UTC() directly when determining the cutoff for deleting indices.

Highlights

• Bug Fix: The PR fixes a bug in the es-index-cleaner that was causing incorrect index deletion calculations.
• Time Calculation: The PR updates the time calculation logic to use the current time instead of calculating from tomorrow's midnight.

Changelog

• cmd/es-index-cleaner/main.go
  • Modified the time calculation logic to use time.Now().UTC() to determine the cutoff for deleting indices.
  • Removed the calculation of tomorrow's midnight, simplifying the time calculation process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

The concept of time zones was largely popularized by the expansion of railways in the 19th century, as standardized time became essential for scheduling and avoiding collisions.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the es-index-cleaner to delete indices based on the current time, resolving issue #6236. The change replaces the previous logic that calculated the deletion date based on tomorrow's midnight with a calculation based on the current time. This seems like a good change, but I have a question about it.

Summary of Findings

• Timezone Considerations: The code uses time.Now().UTC() to determine the current time. While this ensures consistency, it's important to verify that the Elasticsearch indices are also created using UTC time. If the indices are created using a different timezone, the deletion logic might not work as expected.

Merge Readiness

The code change appears straightforward and addresses the intended issue. However, it's crucial to ensure that the Elasticsearch indices are created using UTC time to avoid any unexpected behavior. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

[yurishkuro]

The change looks ok but it's a breaking change that should be handled according to our policy that is documented in CONTRIBUTING.