Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow load for plaintex/kuberos when TLS conditions set #6768

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: allow load for plaintex/kuberos when TLS conditions set #6768

wants to merge 3 commits into from

Conversation

sans-sehgal
Copy link

@sans-sehgal sans-sehgal commented Feb 23, 2025 •
edited
Loading

Description of the changes

How was this change tested?

  • connectivity with TLS-enabled Kafka cluster using plaintext authentication.

Checklist

@sans-sehgal sans-sehgal requested a review from a team as a code owner February 23, 2025 00:20
@sans-sehgal sans-sehgal requested a review from jkowall February 23, 2025 00:20
@dosubot dosubot bot added docker Pull requests that update Docker code storage/kafka labels Feb 23, 2025
@sans-sehgal sans-sehgal force-pushed the fixing-TLS-loading-conditions branch from aee228a to 7b99464 Compare February 23, 2025 00:22
@sans-sehgal
feat: allow load for plaintex/kuberos when TLS conditions set
267eab6 
Signed-off-by: sans-sehgal <sanskaarsehgal0099@gmail.com>
@sans-sehgal
fix: lint
0376e08 
Signed-off-by: sans-sehgal <sanskaarsehgal0099@gmail.com>
@sans-sehgal
fix: dependecies
a60f311 
Signed-off-by: sans-sehgal <sanskaarsehgal0099@gmail.com>
@sans-sehgal sans-sehgal force-pushed the fixing-TLS-loading-conditions branch from 359005e to a60f311 Compare February 23, 2025 01:08
yurishkuro
yurishkuro requested changes Feb 23, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR contains lots of unrelated changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro requested changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
docker Pull requests that update Docker code storage/kafka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: kafka: cannot connect to TLS kafka with TLS + plaintext
2 participants
@sans-sehgal @yurishkuro