Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import nop receiver/exporter and add a sample query service config #6687

Merged
merged 6 commits into from
Feb 8, 2025

Conversation

danish9039
Copy link
Contributor

@danish9039 danish9039 commented Feb 6, 2025

Which problem is this PR solving?

Description of the changes

  • import nop receiver ,exporter and create a sample query service configuration named config-query.yaml

How was this change tested?

Checklist

…nfiguration

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 requested a review from a team as a code owner February 6, 2025 19:33
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (a67cd03) to head (b8b7f0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6687      +/-   ##
==========================================
+ Coverage   95.98%   96.00%   +0.02%     
==========================================
  Files         363      363              
  Lines       20608    20610       +2     
==========================================
+ Hits        19780    19787       +7     
+ Misses        632      628       -4     
+ Partials      196      195       -1     
Flag Coverage Δ
badger_v1 9.82% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.79% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.79% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.81% <ø> (ø)
elasticsearch-6.x-v1 19.12% <ø> (ø)
elasticsearch-7.x-v1 19.20% <ø> (ø)
elasticsearch-8.x-v1 19.37% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 10.80% <ø> (ø)
grpc_v2 7.80% <ø> (ø)
kafka-3.x-v1 10.12% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.25% <ø> (ø)
opensearch-2.x-v1 19.25% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.89% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/jaeger/config-query.yaml Outdated Show resolved Hide resolved
cmd/jaeger/internal/components.go Outdated Show resolved Hide resolved
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong config

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
danish9039 and others added 2 commits February 9, 2025 00:20
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@yurishkuro yurishkuro changed the title import nop receiver and exporter and create a sample query service co… Import nop receiver and exporter and create a sample query service co… Feb 8, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) February 8, 2025 21:32
@yurishkuro yurishkuro changed the title Import nop receiver and exporter and create a sample query service co… Import nop receiver and exporter and create a sample query service config Feb 8, 2025
@yurishkuro yurishkuro changed the title Import nop receiver and exporter and create a sample query service config Import nop receiver/exporter and add a sample query service config Feb 8, 2025
@yurishkuro yurishkuro disabled auto-merge February 8, 2025 21:33
@yurishkuro yurishkuro enabled auto-merge (squash) February 8, 2025 21:33
@yurishkuro yurishkuro merged commit 8def385 into jaegertracing:main Feb 8, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants