[refactor] Remove archive reader and writer from remote storage grpc handler #6611
+88
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
commented
Jan 26, 2025
Comment on lines
244
to
245
| ArchiveSpanReader: s.impl.SpanReader() != nil, | ||
| ArchiveSpanWriter: s.impl.SpanWriter() != nil, |
There was a problem hiding this comment.
@yurishkuro should we remove these from the capabilities response altogether?
There was a problem hiding this comment.
we can mark them deprecated in the .proto definition and return false here
yurishkuro
reviewed
Jan 26, 2025
| ArchiveSpanReader: s.impl.ArchiveSpanReader() != nil, | ||
| ArchiveSpanWriter: s.impl.ArchiveSpanWriter() != nil, | ||
| ArchiveSpanReader: s.impl.SpanReader() != nil, | ||
| ArchiveSpanWriter: s.impl.SpanWriter() != nil, | ||
| StreamingSpanWriter: s.impl.StreamingSpanWriter() != nil, | ||
| }, nil | ||
| } | ||
|
|
||
| func (s *GRPCHandler) GetArchiveTrace(r *storage_v1.GetTraceRequest, stream storage_v1.ArchiveSpanReaderPlugin_GetArchiveTraceServer) error { |
There was a problem hiding this comment.
should this return not-implemented error instead?
There was a problem hiding this comment.
@yurishkuro are we okay with making that breaking change?
There was a problem hiding this comment.
this will never be called by grpc-storage
There was a problem hiding this comment.
@yurishkuro is there a reason we can't just remove this then?
mahadzaryab1
commented
Jan 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6611 +/- ##
==========================================
- Coverage 96.03% 96.00% -0.04%
==========================================
Files 365 365
Lines 20654 20616 -38
==========================================
- Hits 19836 19792 -44
- Misses 622 626 +4
- Partials 196 198 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
added
the
changelog:breaking-change
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
reviewed
Jan 26, 2025
yurishkuro
approved these changes
Jan 26, 2025
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
approved these changes
Jan 26, 2025
ekefan
pushed a commit
to ekefan/jaeger
that referenced
this pull request
Jan 26, 2025
…handler (jaegertracing#6611) ## Which problem is this PR solving? - Towards jaegertracing#6065 ## Description of the changes - 🛑 This PR deprecates two fields in the `CapabilitiesResponse`; `ArchiveSpanReader` and `ArchiveSpanWriter` as these capabilities do not exist within grpc storage anymore and are configured externally. 🛑 - 🛑 This PR deprecates the ArchiveSpanReaderPlugin and ArchvieSpanWriterPlugin 🛑 ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
CapabilitiesResponse;ArchiveSpanReaderandArchiveSpanWriteras these capabilities do not exist within grpc storage anymore and are configured externally. 🛑How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test