Create a /quality-metrics endpoint #6608

ADI-ROXX · 2025-01-25T16:34:24Z

Which problem is this PR solving?

Resolves Create dummy /quality-metrics endpoint #6607
Related to [Feature]: Make changes to allow for /api/quality-metrics to work jaeger-ui#2640
Related to the PR: Make changes to allow for /api/quality-metrics to work jaeger-ui#2641

Description of the changes

How was this change tested?

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: npm run lint and npm run test

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

codecov · 2025-01-25T16:45:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (8bf69c7) to head (6f434d4).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6608      +/-   ##
==========================================
+ Coverage   95.99%   96.04%   +0.04%     
==========================================
  Files         363      364       +1     
  Lines       20568    20699     +131     
==========================================
+ Hits        19745    19881     +136     
+ Misses        628      624       -4     
+ Partials      195      194       -1

Flag	Coverage Δ
badger_v1	`9.80% <ø> (-0.03%)`	⬇️
badger_v2	`1.81% <ø> (-0.01%)`	⬇️
cassandra-4.x-v1-manual	`14.76% <ø> (-0.04%)`	⬇️
cassandra-4.x-v2-auto	`1.80% <ø> (-0.01%)`	⬇️
cassandra-4.x-v2-manual	`1.80% <ø> (-0.01%)`	⬇️
cassandra-5.x-v1-manual	`14.76% <ø> (-0.04%)`	⬇️
cassandra-5.x-v2-auto	`1.80% <ø> (-0.01%)`	⬇️
cassandra-5.x-v2-manual	`1.80% <ø> (-0.01%)`	⬇️
elasticsearch-6.x-v1	`19.08% <ø> (-0.05%)`	⬇️
elasticsearch-7.x-v1	`19.16% <ø> (-0.05%)`	⬇️
elasticsearch-8.x-v1	`19.33% <ø> (-0.05%)`	⬇️
elasticsearch-8.x-v2	`1.81% <ø> (-0.01%)`	⬇️
grpc_v1	`10.77% <ø> (-0.03%)`	⬇️
grpc_v2	`7.78% <ø> (-0.03%)`	⬇️
kafka-3.x-v1	`10.09% <ø> (-0.03%)`	⬇️
kafka-3.x-v2	`1.81% <ø> (-0.01%)`	⬇️
memory_v2	`1.81% <ø> (-0.01%)`	⬇️
opensearch-1.x-v1	`19.21% <ø> (-0.05%)`	⬇️
opensearch-2.x-v1	`19.21% <ø> (-0.05%)`	⬇️
opensearch-2.x-v2	`1.81% <ø> (-0.01%)`	⬇️
tailsampling-processor	`0.48% <ø> (-0.01%)`	⬇️
unittests	`94.93% <100.00%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/query/app/http_handler.go

yurishkuro

include a screenshot demonstrating that this works in the UI

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

yaten2302 · 2025-01-30T18:42:29Z

Hey @ADI-ROXX , I was working on this PR: Migrate DetailsCard from class based to function based component, but there's a problem that before migrating, the /quality-metrics endpoint must be present in order to show the correct results.
I see that you're working on this issue, may we collaborate on this, if it's fine with you?
Thanks

cmd/query/app/http_handler.go

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

ADI-ROXX · 2025-02-03T05:14:48Z

Hey @ADI-ROXX , I was working on this PR: Migrate DetailsCard from class based to function based component, but there's a problem that before migrating, the /quality-metrics endpoint must be present in order to show the correct results. I see that you're working on this issue, may we collaborate on this, if it's fine with you? Thanks

Hi @yaten2302. I don't think that this PR has much change left. However, if I feel difficulty in something, I will let you know.

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

ADI-ROXX · 2025-02-08T09:05:57Z

@yurishkuro Do you have any idea for any test in mind for data.go? I don't have any idea for the same.

cmd/query/app/qualitymetrics/empty_test.go

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

… dummyRoutes

ADI-ROXX · 2025-02-11T14:58:40Z

@yurishkuro Can you review it once? I don't think that any more changes are left for this PR.

yurishkuro · 2025-02-11T15:11:56Z

cmd/query/app/qualitymetrics/data_types.go

+package qualitymetrics
+
+// TQualityMetrics represents the entire quality metrics response.
+type TQualityMetrics struct {


what's the answer to the question?

general advice - it's a poor choice to resolve comments without actually responding or fixing the code.

cmd/query/app/qualitymetrics/data_test.go

cmd/query/app/qualitymetrics/data.go

yurishkuro · 2025-02-11T15:15:27Z

Minor nits, otherwise looks great. Nice to have a proper JSON data model documented in code.

ADI-ROXX · 2025-02-11T15:41:32Z

I will commit the changes soon. I am getting a few errors in the ui(probably local issues since I didn't change anything). I will push the final changes after checking the ui one last time.

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

… dummyRoutes

ADI-ROXX · 2025-02-11T17:23:56Z

@yurishkuro I have made all the minor changes. Can you look once? Thank you.

Also, I have to ask a general question:
Is there any GUI tool that you use for testing on local for various things like coverage, tests, and linting, or do you use make cover, test, and lint in the terminal?

yurishkuro · 2025-02-11T18:15:39Z

for Go coverage I use VSCode's built-in package coverage command

ADI-ROXX · 2025-02-11T18:19:12Z

Ok. I'll try to integrate that in my workspace.

cmd/query/app/qualitymetrics/data.go

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

yurishkuro · 2025-02-12T12:43:49Z

Where is the pr for ui changes? I only see an issue linked

ADI-ROXX · 2025-02-12T17:03:33Z

Where is the pr for ui changes?

Fixed

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

yurishkuro · 2025-02-12T17:52:47Z

cmd/query/app/qualitymetrics/data_test.go

+
+func TestGetSampleData(t *testing.T) {
+	data := GetSampleData()
+	assert.NotEmpty(t, data.TraceQualityDocumentationLink, "TraceQualityDocumentationLink should not be empty")


tip: you don't need these messages in asserts, the assert itself already provides very readable error message with line number

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

## Which problem is this PR solving? - Resolves #2640 - jaegertracing/jaeger#6607 ## Description of the changes - introduce config option for the API endpoint and change it to `/api/quality-metrics' as implemented in jaegertracing/jaeger#6608 ## How was this change tested? - manually ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Yuri Shkuro <github@ysh.us>

## Which problem is this PR solving? - Follow up to #6608 - Resolves #6607 ## Description of the changes - Remove intermediate `data:` element from the response - Match response to what the UI expects - Fix unit test that wasn't testing the output ## How was this change tested? - unit tests - manual test with jaegertracing/jaeger-ui#2641 --------- Signed-off-by: Yuri Shkuro <github@ysh.us>

ADI-ROXX added 2 commits January 23, 2025 23:13

Return 400

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

1932a2b

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

Merge remote-tracking branch 'upstream/main'

5288d8c

ADI-ROXX requested a review from a team as a code owner January 25, 2025 16:34

ADI-ROXX requested a review from pavolloffay January 25, 2025 16:34

Create a /quality-metrics endpoint

a9067ad

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

ADI-ROXX force-pushed the dummyRoutes branch from 1415973 to a9067ad Compare January 25, 2025 16:36

yurishkuro reviewed Jan 25, 2025

View reviewed changes

cmd/query/app/http_handler.go Outdated Show resolved Hide resolved

yurishkuro reviewed Jan 25, 2025

View reviewed changes

ADI-ROXX added 3 commits January 28, 2025 21:28

Dummy data in the correct format

8ca78a8

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

lint

6b68418

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

interface{}->any for lint

1861fd4

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

ADI-ROXX force-pushed the dummyRoutes branch from b71008e to 1861fd4 Compare January 29, 2025 05:40

yurishkuro reviewed Jan 30, 2025

View reviewed changes

cmd/query/app/http_handler.go Outdated Show resolved Hide resolved

cmd/query/app/http_handler.go Outdated Show resolved Hide resolved

cmd/query/app/http_handler.go Outdated Show resolved Hide resolved

yurishkuro mentioned this pull request Feb 2, 2025

Create a /deep-dependencies endpoint #6654

Open

4 tasks

Added tests for coverage

ce7929e

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

yurishkuro added the changelog:bugfix-or-minor-feature label Feb 3, 2025

app/qualitymetrics

3c434b6

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

ADI-ROXX force-pushed the dummyRoutes branch from e04b283 to 3c434b6 Compare February 8, 2025 08:54

Merge branch 'main' into dummyRoutes

6f55732

yurishkuro reviewed Feb 9, 2025

View reviewed changes

cmd/query/app/qualitymetrics/empty_test.go Outdated Show resolved Hide resolved

ADI-ROXX and others added 3 commits February 10, 2025 11:22

basic-test

eb6f2e6

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

Merge branch 'dummyRoutes' of https://github.com/ADI-ROXX/jaeger into…

8d5df2d

… dummyRoutes

Merge branch 'main' into dummyRoutes

55aa6d9

yurishkuro reviewed Feb 11, 2025

View reviewed changes

cmd/query/app/qualitymetrics/data_test.go Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 11, 2025

View reviewed changes

cmd/query/app/qualitymetrics/data.go Outdated Show resolved Hide resolved

ADI-ROXX added 2 commits February 11, 2025 22:41

minor adjustments

5646223

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

Merge branch 'dummyRoutes' of https://github.com/ADI-ROXX/jaeger into…

9a8841b

… dummyRoutes

yurishkuro reviewed Feb 11, 2025

View reviewed changes

cmd/query/app/qualitymetrics/data.go Outdated Show resolved Hide resolved

new link

b18cc7e

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

ADI-ROXX mentioned this pull request Feb 12, 2025

Make changes to allow for /api/quality-metrics to work jaegertracing/jaeger-ui#2641

Merged

4 tasks

Not be empty

8fdd9c6

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

yurishkuro reviewed Feb 12, 2025

View reviewed changes

Remove assert string

6f434d4

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>

yurishkuro approved these changes Feb 12, 2025

View reviewed changes

yurishkuro merged commit 42cd2b9 into jaegertracing:main Feb 12, 2025
55 checks passed

yaten2302 mentioned this pull request Feb 14, 2025

Migrate DetailsCard from class based to function based component jaegertracing/jaeger-ui#2637

Closed

4 tasks

yurishkuro mentioned this pull request Feb 15, 2025

Fix /qualitymetrics to return data in expected format #6733

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a /quality-metrics endpoint #6608

Create a /quality-metrics endpoint #6608

ADI-ROXX commented Jan 25, 2025 •

edited

Loading

codecov bot commented Jan 25, 2025 •

edited

Loading

yurishkuro left a comment

yaten2302 commented Jan 30, 2025

ADI-ROXX commented Feb 3, 2025

ADI-ROXX commented Feb 8, 2025 •

edited

Loading

ADI-ROXX commented Feb 11, 2025

yurishkuro Feb 11, 2025

yurishkuro Feb 12, 2025

yurishkuro Feb 12, 2025

yurishkuro commented Feb 11, 2025

ADI-ROXX commented Feb 11, 2025

ADI-ROXX commented Feb 11, 2025

yurishkuro commented Feb 11, 2025

ADI-ROXX commented Feb 11, 2025

yurishkuro commented Feb 12, 2025

ADI-ROXX commented Feb 12, 2025

yurishkuro Feb 12, 2025

Create a /quality-metrics endpoint #6608

Create a /quality-metrics endpoint #6608

Conversation

ADI-ROXX commented Jan 25, 2025 • edited Loading

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

codecov bot commented Jan 25, 2025 • edited Loading

Codecov Report

yurishkuro left a comment

Choose a reason for hiding this comment

yaten2302 commented Jan 30, 2025

ADI-ROXX commented Feb 3, 2025

ADI-ROXX commented Feb 8, 2025 • edited Loading

ADI-ROXX commented Feb 11, 2025

yurishkuro Feb 11, 2025

Choose a reason for hiding this comment

yurishkuro Feb 12, 2025

Choose a reason for hiding this comment

yurishkuro Feb 12, 2025

Choose a reason for hiding this comment

yurishkuro commented Feb 11, 2025

ADI-ROXX commented Feb 11, 2025

ADI-ROXX commented Feb 11, 2025

yurishkuro commented Feb 11, 2025

ADI-ROXX commented Feb 11, 2025

yurishkuro commented Feb 12, 2025

ADI-ROXX commented Feb 12, 2025

yurishkuro Feb 12, 2025

Choose a reason for hiding this comment

ADI-ROXX commented Jan 25, 2025 •

edited

Loading

codecov bot commented Jan 25, 2025 •

edited

Loading

ADI-ROXX commented Feb 8, 2025 •

edited

Loading