diff --git a/cmd/remote-storage/app/server.go b/cmd/remote-storage/app/server.go index 577df153f20..eecda1fb3c4 100644 --- a/cmd/remote-storage/app/server.go +++ b/cmd/remote-storage/app/server.go @@ -38,12 +38,11 @@ type storageFactory interface { CreateSpanReader() (spanstore.Reader, error) CreateSpanWriter() (spanstore.Writer, error) CreateDependencyReader() (dependencystore.Reader, error) - InitArchiveStorage(logger *zap.Logger) (spanstore.Reader, spanstore.Writer) } // NewServer creates and initializes Server. func NewServer(options *Options, storageFactory storageFactory, tm *tenancy.Manager, telset telemetry.Settings) (*Server, error) { - handler, err := createGRPCHandler(storageFactory, telset.Logger) + handler, err := createGRPCHandler(storageFactory) if err != nil { return nil, err } @@ -60,7 +59,7 @@ func NewServer(options *Options, storageFactory storageFactory, tm *tenancy.Mana }, nil } -func createGRPCHandler(f storageFactory, logger *zap.Logger) (*shared.GRPCHandler, error) { +func createGRPCHandler(f storageFactory) (*shared.GRPCHandler, error) { reader, err := f.CreateSpanReader() if err != nil { return nil, err @@ -81,10 +80,6 @@ func createGRPCHandler(f storageFactory, logger *zap.Logger) (*shared.GRPCHandle StreamingSpanWriter: func() spanstore.Writer { return nil }, } - ar, aw := f.InitArchiveStorage(logger) - impl.ArchiveSpanReader = func() spanstore.Reader { return ar } - impl.ArchiveSpanWriter = func() spanstore.Writer { return aw } - handler := shared.NewGRPCHandler(impl) return handler, nil } diff --git a/plugin/storage/grpc/shared/grpc_handler.go b/plugin/storage/grpc/shared/grpc_handler.go index 3a2f3e3b681..421476ee927 100644 --- a/plugin/storage/grpc/shared/grpc_handler.go +++ b/plugin/storage/grpc/shared/grpc_handler.go @@ -38,9 +38,6 @@ type GRPCHandlerStorageImpl struct { SpanWriter func() spanstore.Writer DependencyReader func() dependencystore.Reader - ArchiveSpanReader func() spanstore.Reader - ArchiveSpanWriter func() spanstore.Writer - StreamingSpanWriter func() spanstore.Writer } @@ -244,45 +241,16 @@ func (*GRPCHandler) sendSpans(spans []*model.Span, sendFn func(*storage_v1.Spans func (s *GRPCHandler) Capabilities(context.Context, *storage_v1.CapabilitiesRequest) (*storage_v1.CapabilitiesResponse, error) { return &storage_v1.CapabilitiesResponse{ - ArchiveSpanReader: s.impl.ArchiveSpanReader() != nil, - ArchiveSpanWriter: s.impl.ArchiveSpanWriter() != nil, + ArchiveSpanReader: s.impl.SpanReader() != nil, + ArchiveSpanWriter: s.impl.SpanWriter() != nil, StreamingSpanWriter: s.impl.StreamingSpanWriter() != nil, }, nil } func (s *GRPCHandler) GetArchiveTrace(r *storage_v1.GetTraceRequest, stream storage_v1.ArchiveSpanReaderPlugin_GetArchiveTraceServer) error { - reader := s.impl.ArchiveSpanReader() - if reader == nil { - return status.Error(codes.Unimplemented, "not implemented") - } - trace, err := reader.GetTrace(stream.Context(), spanstore.GetTraceParameters{ - TraceID: r.TraceID, - StartTime: r.StartTime, - EndTime: r.EndTime, - }) - if errors.Is(err, spanstore.ErrTraceNotFound) { - return status.Error(codes.NotFound, spanstore.ErrTraceNotFound.Error()) - } - if err != nil { - return err - } - - err = s.sendSpans(trace.Spans, stream.Send) - if err != nil { - return err - } - - return nil + return s.GetTrace(r, stream) } func (s *GRPCHandler) WriteArchiveSpan(ctx context.Context, r *storage_v1.WriteSpanRequest) (*storage_v1.WriteSpanResponse, error) { - writer := s.impl.ArchiveSpanWriter() - if writer == nil { - return nil, status.Error(codes.Unimplemented, "not implemented") - } - err := writer.WriteSpan(ctx, r.Span) - if err != nil { - return nil, err - } - return &storage_v1.WriteSpanResponse{}, nil + return s.WriteSpan(ctx, r) }