Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin agent version to 1.62.0 #2790

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rubenvp8510
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@rubenvp8510 rubenvp8510 changed the title Pin agent version [WIP] Pin agent version Jan 17, 2025
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (849fd7c) to head (1ac8e97).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/util.go 0.00% 9 Missing ⚠️
pkg/version/main.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
- Coverage   74.74%   74.63%   -0.12%     
==========================================
  Files         124      124              
  Lines       10497    10513      +16     
==========================================
  Hits         7846     7846              
- Misses       2454     2470      +16     
  Partials      197      197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@rubenvp8510 rubenvp8510 changed the title [WIP] Pin agent version Pin agent version to 1.62.0 Jan 18, 2025
@@ -29,6 +29,8 @@ BUNDLE_IMG ?= ${IMG_PREFIX}/${OPERATOR_NAME}-bundle:$(addprefix v,${VERSION})
OUTPUT_BINARY ?= "$(BIN_DIR)/jaeger-operator"
VERSION_PKG ?= "github.com/jaegertracing/jaeger-operator/pkg/version"
export JAEGER_VERSION ?= "$(shell grep jaeger= versions.txt | awk -F= '{print $$2}')"
export JAEGER_AGENT_VERSION ?= "1.62.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment why 1.62.0 is used would be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants