Choose the newer autoscaling version by default #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
|
@rubenvp8510 can you take a look at this PR? Thanks! |
|
Is it possible to write small unit test for this? |
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Done |
|
small format issue, the CI is complainiing about it |
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2374 +/- ##
=======================================
Coverage 87.70% 87.71%
=======================================
Files 102 102
Lines 7266 7268 +2
=======================================
+ Hits 6373 6375 +2
Misses 697 697
Partials 196 196 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
autoscaling/v2beta2instead ofautoscaling/v2if both APIs are available #2367