Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share setup sub-action in CI #615

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Share setup sub-action in CI #615

merged 4 commits into from
Oct 31, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Oct 30, 2024

What this PR does

  • Extracts common k8s setup steps into a reusable action
  • Move install test into a separate job

Which issue this PR fixes

The CI testing of the chart does not cover installing 3rd party storage backends. PR #614 adds an extra test but either has to do it sequentially within the single job or replicate a lot of setup for another job / workflow. With this refactoring #614 would be able to add a new job to the existing workflow with minimal amount of boiler plate.

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro marked this pull request as ready for review October 30, 2024 19:46
@yurishkuro yurishkuro merged commit 1db9b63 into main Oct 31, 2024
3 checks passed
@yurishkuro yurishkuro deleted the share-setup branch October 31, 2024 14:59
hellspawn679 added a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
* Share setup sub-action in CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 2, 2024
* Share setup sub-action in CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: mehul <mehulsharam4786@gmail.com>

Update Chart.yaml

Signed-off-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant