Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger] add possibility of overriting the namespace #599

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/jaeger/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 1.53.0
description: A Jaeger Helm chart for Kubernetes
name: jaeger
type: application
version: 3.3.1
version: 3.4.0
# CronJobs require v1.21
kubeVersion: ">= 1.21-0"
keywords:
Expand Down
11 changes: 11 additions & 0 deletions charts/jaeger/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,17 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
{{- end -}}
{{- end -}}

{{/*
Determine Namespace based on the inputs
*/}}
{{- define "jaeger.namespace" -}}
{{- if .Values.namespaceOverride }}
{{- .Values.namespaceOverride -}}
{{- else -}}
{{- .Release.Namespace -}}
{{- end -}}
{{- end -}}

{{- define "cassandra.host" -}}
{{- if .Values.provisionDataStore.cassandra -}}
{{- if .Values.storage.cassandra.nameOverride }}
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/agent-ds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: DaemonSet
metadata:
name: {{ template "jaeger.agent.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: agent
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/agent-sa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "jaeger.agent.serviceAccountName" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: agent
Expand Down
2 changes: 2 additions & 0 deletions charts/jaeger/templates/agent-servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ metadata:
name: {{ template "jaeger.agent.name" . }}
{{- if .Values.agent.serviceMonitor.namespace }}
namespace: {{ .Values.agent.serviceMonitor.namespace }}
{{- else }}
namespace: {{ include "jaeger.namespace" . }}
{{- end }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/agent-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ template "jaeger.agent.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: agent
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/allinone-agent-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ template "jaeger.agent.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: service-agent
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/allinone-collector-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ template "jaeger.collector.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: service-collector
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/allinone-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: {{ include "jaeger.fullname" . }}-sampling-strategies
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: all-in-one
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/allinone-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ template "jaeger.fullname" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: all-in-one
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/allinone-ing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ template "jaeger.query.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: all-in-one
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/allinone-query-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ template "jaeger.query.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: service-query
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/allinone-sa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "jaeger.fullname" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: all-in-one
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/cassandra-schema-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ apiVersion: batch/v1
kind: Job
metadata:
name: {{ include "jaeger.fullname" . }}-cassandra-schema
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: cassandra-schema
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/cassandra-schema-sa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "jaeger.cassandraSchema.serviceAccountName" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: cassandra-schema
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/cassandra-secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Secret
metadata:
name: {{ include "jaeger.fullname" . }}-cassandra
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
type: Opaque
Expand Down
2 changes: 1 addition & 1 deletion charts/jaeger/templates/collector-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: {{ include "jaeger.fullname" . }}-sampling-strategies
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: collector
data:
strategies.json: |-
{{ tpl .Values.collector.samplingConfig . | indent 4 }}
{{- end }}

3 changes: 2 additions & 1 deletion charts/jaeger/templates/collector-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ template "jaeger.collector.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: collector
Expand Down Expand Up @@ -38,7 +39,7 @@ spec:
securityContext:
{{- toYaml .Values.collector.podSecurityContext | nindent 8 }}
serviceAccountName: {{ template "jaeger.collector.serviceAccountName" . }}
{{- include "collector.imagePullSecrets" . | nindent 6 }}
{{- include "collector.imagePullSecrets" . | nindent 6 }}
{{- if .Values.collector.initContainers }}
initContainers:
{{- toYaml .Values.collector.initContainers | nindent 8 }}
Expand Down
11 changes: 6 additions & 5 deletions charts/jaeger/templates/collector-hpa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: {{ include "common.capabilities.hpa.apiVersion" ( dict "context" $ )
kind: HorizontalPodAutoscaler
metadata:
name: {{ template "jaeger.collector.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: collector
Expand All @@ -22,22 +23,22 @@ spec:
target:
averageUtilization: {{ .Values.collector.autoscaling.targetMemoryUtilizationPercentage }}
type: Utilization
{{- else }}
{{- else }}
targetAverageUtilization: {{ .Values.collector.autoscaling.targetMemoryUtilizationPercentage }}
{{- end }}
{{- end }}
{{- end }}
- type: Resource
resource:
name: cpu
{{- if eq "autoscaling/v2" (include "common.capabilities.hpa.apiVersion" ( dict "context" $ )) }}
{{- if eq "autoscaling/v2" (include "common.capabilities.hpa.apiVersion" ( dict "context" $ )) }}
target:
averageUtilization: {{ .Values.collector.autoscaling.targetCPUUtilizationPercentage | default 80 }}
type: Utilization
{{- else }}
{{- else }}
targetAverageUtilization: {{ .Values.collector.autoscaling.targetCPUUtilizationPercentage | default 80 }}
{{- end }}
{{- with .Values.collector.autoscaling.behavior }}
behavior:
{{- toYaml . | nindent 4 }}
{{- end }}
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions charts/jaeger/templates/collector-ing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ apiVersion: {{ include "common.capabilities.ingress.apiVersion" $ }}
kind: Ingress
metadata:
name: {{ template "jaeger.collector.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
{{- if .Values.collector.ingress.labels }}
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/collector-sa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "jaeger.collector.serviceAccountName" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: collector
Expand Down
4 changes: 3 additions & 1 deletion charts/jaeger/templates/collector-servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ metadata:
name: {{ template "jaeger.collector.name" . }}
{{- if .Values.collector.serviceMonitor.namespace }}
namespace: {{ .Values.collector.serviceMonitor.namespace }}
{{- else }}
namespace: {{ include "jaeger.namespace" . }}
{{- end }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
Expand Down Expand Up @@ -36,7 +38,7 @@ spec:
{{- end }}
namespaceSelector:
matchNames:
- {{ .Release.Namespace }}
- {{ include "jaeger.namespace" . }}
selector:
matchLabels:
app.kubernetes.io/component: collector
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/collector-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ template "jaeger.collector.name" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: collector
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/elasticsearch-secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Secret
metadata:
name: {{ include "jaeger.fullname" . }}-elasticsearch
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
annotations:
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/es-index-cleaner-cronjob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: {{ include "common.capabilities.cronjob.apiVersion" $ }}
kind: CronJob
metadata:
name: {{ include "jaeger.fullname" . }}-es-index-cleaner
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: es-index-cleaner
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/es-index-cleaner-sa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "jaeger.esIndexCleaner.serviceAccountName" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: es-index-cleaner
Expand Down
3 changes: 2 additions & 1 deletion charts/jaeger/templates/es-lookback-cronjob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: {{ include "common.capabilities.cronjob.apiVersion" $ }}
kind: CronJob
metadata:
name: {{ include "jaeger.fullname" . }}-es-lookback
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: es-lookback
Expand Down Expand Up @@ -38,7 +39,7 @@ spec:
{{- end }}
spec:
serviceAccountName: {{ template "jaeger.esLookback.serviceAccountName" . }}
{{- include "esLookback.imagePullSecrets" . | nindent 10 }}
{{- include "esLookback.imagePullSecrets" . | nindent 10 }}
securityContext:
{{- toYaml .Values.esLookback.podSecurityContext | nindent 12 }}
restartPolicy: OnFailure
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/es-lookback-sa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "jaeger.esLookback.serviceAccountName" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: es-lookback
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/es-rollover-cronjob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: {{ include "common.capabilities.cronjob.apiVersion" $ }}
kind: CronJob
metadata:
name: {{ include "jaeger.fullname" . }}-es-rollover
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: es-rollover
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/es-rollover-hook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: batch/v1
kind: Job
metadata:
name: {{ include "jaeger.fullname" . }}-es-rollover-init
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: es-rollover-init
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/es-rollover-sa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "jaeger.esRollover.serviceAccountName" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: es-index-rollover
Expand Down
3 changes: 2 additions & 1 deletion charts/jaeger/templates/hotrod-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "jaeger.fullname" . }}-hotrod
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: hotrod
Expand All @@ -21,7 +22,7 @@ spec:
securityContext:
{{- toYaml .Values.hotrod.podSecurityContext | nindent 8 }}
serviceAccountName: {{ template "jaeger.hotrod.serviceAccountName" . }}
{{- include "hotrod.imagePullSecrets" . | nindent 6 }}
{{- include "hotrod.imagePullSecrets" . | nindent 6 }}
containers:
- name: {{ include "jaeger.fullname" . }}-hotrod
securityContext:
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/hotrod-ing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ apiVersion: {{ include "common.capabilities.ingress.apiVersion" $ }}
kind: Ingress
metadata:
name: {{ include "jaeger.fullname" . }}-hotrod
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: hotrod
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/hotrod-sa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "jaeger.hotrod.serviceAccountName" . }}
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: hotrod
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/hotrod-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ include "jaeger.fullname" . }}-hotrod
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: hotrod
Expand Down
1 change: 1 addition & 0 deletions charts/jaeger/templates/ingester-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "jaeger.fullname" . }}-ingester
namespace: {{ include "jaeger.namespace" . }}
labels:
{{- include "jaeger.labels" . | nindent 4 }}
app.kubernetes.io/component: ingester
Expand Down
Loading
Loading