[jaeger] allInOne add option tolerations #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenlujjj
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
chenlujjj
force-pushed
the
allinone-tolerations
branch
from
6b94969 to
647b6a0
Compare
|
@chenlujjj thank you for your PR. Could you, please, GPG-sign your commits? You have to also bump the chart version. See other PRs. |
pavelnikolov
requested changes
Jul 11, 2024
chenlujjj
force-pushed
the
allinone-tolerations
branch
from
647b6a0 to
e594f48
Compare
|
sure, let me check how to do that |
Signed-off-by: chenlujjj <953546398@qq.com>
chenlujjj
force-pushed
the
allinone-tolerations
branch
from
e594f48 to
76b42dd
Compare
|
hi @pavelnikolov I've signed the commit, thanks |
pavelnikolov
approved these changes
Jul 11, 2024
hellspawn679
pushed a commit
to hellspawn679/helm-charts
that referenced
this pull request
Nov 1, 2024
Signed-off-by: chenlujjj <953546398@qq.com> Signed-off-by: mehul <mehulsharam4786@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add
tolerationsoption to allInOne deploymentChecklist
[jaeger]or[jaeger-operator])