From d80b31f3782e14ac131086738b465194d4d39d2f Mon Sep 17 00:00:00 2001 From: Jack Firth Date: Fri, 30 Aug 2024 17:10:34 -0700 Subject: [PATCH 1/2] Log broken refactoring attempts as warnings This allows Resyntax to continue attempting to apply other refactoring rules when one rule breaks. --- main.rkt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/main.rkt b/main.rkt index 6abe3a0..d76b03b 100644 --- a/main.rkt +++ b/main.rkt @@ -54,10 +54,9 @@ (with-handlers ([exn:fail? (λ (e) - (define message - (format "~a: refactoring attempt failed\n syntax: ~e\n cause: ~e" - (object-name rule) syntax e)) - (raise (exn:fail:refactoring message (current-continuation-marks) rule syntax e)))]) + (log-resyntax-warning "~a: refactoring attempt failed\n syntax: ~e\n cause: ~e" + (object-name rule) syntax e) + absent)]) (guarded-block (guard-match (present replacement) (refactoring-rule-refactor rule syntax #:analysis analysis) From 3024f281a5709a1a347772c9d926b8bb9e82c241 Mon Sep 17 00:00:00 2001 From: Jack Firth Date: Fri, 30 Aug 2024 17:12:36 -0700 Subject: [PATCH 2/2] Bump failed refactoring attempt log level --- main.rkt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main.rkt b/main.rkt index d76b03b..33f02b9 100644 --- a/main.rkt +++ b/main.rkt @@ -54,8 +54,8 @@ (with-handlers ([exn:fail? (λ (e) - (log-resyntax-warning "~a: refactoring attempt failed\n syntax: ~e\n cause: ~e" - (object-name rule) syntax e) + (log-resyntax-error "~a: refactoring attempt failed\n syntax: ~e\n cause: ~e" + (object-name rule) syntax e) absent)]) (guarded-block (guard-match (present replacement)