Automatically infer original splices #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for the `ORIGINAL-SPLICE` markup in syntax replacements by automatically detecting when a sequence of subforms in a replacement are left untouched. This commit removes some uses of `ORIGINAL-SPLICE` to validate the implementation, but not all.
jackfirth
added a commit
that referenced
this pull request
Aug 28, 2024
The original splice inference system implemented in #243 makes it unnecessary.
Merged
jackfirth
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the need for the
ORIGINAL-SPLICEmarkup in syntax replacements by automatically detecting when a sequence of subforms in a replacement is left untouched. It also removes some uses ofORIGINAL-SPLICEto validate the implementation, but not all.