Don't inline returned definitions when they're recursive (#438)

jackfirth · Jan 3, 2025 · 2aba64a · 2aba64a
1 parent 6a4aa1b
commit 2aba64a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/default-recommendations/definition-shortcuts-test.rkt b/default-recommendations/definition-shortcuts-test.rkt
@@ -138,6 +138,14 @@ test: "immediately used variable definition cannot be inlined"
 ------------------------------
 
 
+test: "immediately returned recursive definition cannot be inlined"
+------------------------------
+(define (foo)
+  (define x (list (lambda () x)))
+  x)
+------------------------------
+
+
 test: "inlining immediately returned variable definition doesn't reformat entire context"
 ------------------------------
 (define (foo)

diff --git a/default-recommendations/definition-shortcuts.rkt b/default-recommendations/definition-shortcuts.rkt
@@ -11,6 +11,7 @@
 
 (require (for-syntax racket/base)
          racket/list
+         racket/match
          rebellion/private/static-name
          resyntax/base
          syntax/parse)
@@ -35,6 +36,9 @@
   #:literals (define)
   (~seq body-before ... (~and definition (define id1:id expr)) id2:id)
   #:when (free-identifier=? #'id1 #'id2)
+  #:when (match (syntax-property #'id1 'identifier-usages)
+           [(list _) #true]
+           [_ #false])
   #:with replacement #'(~replacement expr #:original-splice (definition id2))
   #:with focused (if (empty? (attribute body-before))
                      #'replacement