From 15fe0865c5fb455920ef9b5029bb8e2f1299f01a Mon Sep 17 00:00:00 2001 From: Jack Firth Date: Mon, 2 Sep 2024 04:06:50 -0700 Subject: [PATCH] Fix a bug in `ignored-map-to-for-each` --- default-recommendations/list-shortcuts-test.rkt | 7 +++++++ default-recommendations/list-shortcuts.rkt | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/default-recommendations/list-shortcuts-test.rkt b/default-recommendations/list-shortcuts-test.rkt index cf86f35..8ebe744 100644 --- a/default-recommendations/list-shortcuts-test.rkt +++ b/default-recommendations/list-shortcuts-test.rkt @@ -154,3 +154,10 @@ test: "ignored map expression refactorable to for-each" ; comment after (displayln "foo")) ------------------------------ + + +test: "used map expression not refactorable to for-each" +------------------------------ +(define (f func xs ys zs) + (map func xs ys zs)) +------------------------------ diff --git a/default-recommendations/list-shortcuts.rkt b/default-recommendations/list-shortcuts.rkt index bfd0751..d3e51c2 100644 --- a/default-recommendations/list-shortcuts.rkt +++ b/default-recommendations/list-shortcuts.rkt @@ -122,7 +122,7 @@ (define-definition-context-refactoring-rule ignored-map-to-for-each #:description "The result of this `map` expression is unused. Consider using `for-each` instead." #:literals (map) - (~seq body-before ... (~and map-expr (map proc list ...)) body-after ...) + (~seq body-before ... (~and map-expr (map proc list ...)) body-after ...+) (body-before ... (~replacement (for-each proc list ...) #:original map-expr) body-after ...))