Fix a bug in ignored-map-to-for-each

jackfirth · Sep 2, 2024 · 15fe086 · 15fe086
1 parent 1895321
commit 15fe086
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/default-recommendations/list-shortcuts-test.rkt b/default-recommendations/list-shortcuts-test.rkt
@@ -154,3 +154,10 @@ test: "ignored map expression refactorable to for-each"
   ; comment after
   (displayln "foo"))
 ------------------------------
+
+
+test: "used map expression not refactorable to for-each"
+------------------------------
+(define (f func xs ys zs)
+  (map func xs ys zs))
+------------------------------
diff --git a/default-recommendations/list-shortcuts.rkt b/default-recommendations/list-shortcuts.rkt
@@ -122,7 +122,7 @@
 (define-definition-context-refactoring-rule ignored-map-to-for-each
   #:description "The result of this `map` expression is unused. Consider using `for-each` instead."
   #:literals (map)
-  (~seq body-before ... (~and map-expr (map proc list ...)) body-after ...)
+  (~seq body-before ... (~and map-expr (map proc list ...)) body-after ...+)
   (body-before ... (~replacement (for-each proc list ...) #:original map-expr) body-after ...))