New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin fails if geocode source filed is null or empty #2

Open

cruonline opened this issue Dec 10, 2020 · 0 comments

cruonline commented Dec 10, 2020

If one of the entities in the collection contains null, geocode API responds with 400 error.

"Invalid request. Missing the 'address', 'components', 'latlng' or 'place_id' parameter"

Seems, plugin tries to process this response and logs multiple errors.

GmapGeocode > Failed to add node: Duplicate key for property id: ####
Missing typeName for reference in field: geocode

Maybe checking the source field before sending a request would be a better approach?
Also, some error handling for geocode API wouldn't hurt ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment