Skip to content

Commit

Permalink
Merge pull request #32 from ronnyhdez/T28
Browse files Browse the repository at this point in the history
T28 Changes in order to submit package
  • Loading branch information
FvD authored May 26, 2020
2 parents 460d5a0 + e5bf8fb commit ced9b33
Show file tree
Hide file tree
Showing 13 changed files with 47 additions and 47 deletions.
4 changes: 3 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
^lacramr\.Rproj$
^lacrmr\.Rproj$
^\.Rproj\.user$
^doc$
^docs$
^Meta$
^README\.Rmd$

8 changes: 5 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ Authors@R: c(
role = "aut",
email="frans@ixpantia.com"))
Description: Connect to the Less Annoying CRM API to get your data clean and tidy.
License: GPL + file LICENCE
License: GPL-3 | file LICENSE
URL: https://ixpantia.github.io/lacrmr/
BugReports: https://github.com/ixpantia/lacrmr/issues
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.0.2
RoxygenNote: 7.1.0
Depends:
R (>= 3.6),
magrittr
Expand All @@ -37,4 +37,6 @@ Imports:
jsonlite,
janitor,
sjmisc,
httptest
httptest,
stringr,
mockery
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ export(get_contact_information)
export(get_pipeline_report)
export(search_contacts)
import(magrittr)
importFrom(dplyr,"%>%")
19 changes: 19 additions & 0 deletions R/lacrmr.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#' \code{lacrmr} package
#'
#' Connect to the Less Annoying CRM API to get your data clean and tidy.
#'
#' See the README on
#'
#' @docType package
#' @name lacramr
#' @importFrom dplyr %>%
NULL

## quiets concerns of R CMD check re: the .'s that appear in pipelines
utils::globalVariables(c(".", "Success", "result_email", "result_phone",
"result_address", "result_website",
"result_contact_custom_fields", "Result.FirstName",
"result_email", "result_phone", "result_website",
"filter", "select", "Text", "Type", "bind_cols",
"result_custom_fields"
))
2 changes: 1 addition & 1 deletion R/utils.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#' GET call to lacrm API
#' @param x an integer
#' @NoRd
#' @noRd
get_request <- function(user_code, api_token, api_function, ...) {

item <- paste0(...)
Expand Down
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ knitr::opts_chunk$set(
)
```

# lacrmr <a href="url"><img src="img/lacrmR.png" align="right" width="30%"></a>
# lacrmr <a href="url"><img src="man/figures/lacrmR.png" align="right" width="30%"></a>

<!-- badges: start -->
[![CRAN status](https://www.r-pkg.org/badges/version/lacrmr)](https://cran.r-project.org/package=lacrmr)
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

<!-- README.md is generated from README.Rmd. Please edit that file -->

# lacrmr <a href="url"><img src="img/lacrmR.png" align="right" width="30%"></a>
# lacrmr <a href="url"><img src="man/figures/lacrmR.png" align="right" width="30%"></a>

<!-- badges: start -->

Expand Down Expand Up @@ -69,8 +69,8 @@ sales <- get_pipeline_report(user_code = "12454",

## Use glimpse function to check the data frame
dplyr::glimpse(sales)
#> Observations: 7
#> Variables: 33
#> Rows: 7
#> Columns: 33
#> $ result_contact_id <chr> "35041909076033466731615…
#> $ result_user_id <chr> "334595", "435944", "334…
#> $ result_company_id <lgl> NA, NA, NA, NA, NA, NA, …
Expand Down
File renamed without changes
14 changes: 0 additions & 14 deletions man/get_request.Rd

This file was deleted.

12 changes: 12 additions & 0 deletions man/lacramr.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tests/testthat.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
library(testthat)
library(lacrmr)
library(mockery)

test_check("lacrmr")
24 changes: 0 additions & 24 deletions tests/testthat/test-error-warning-msg.R

This file was deleted.

1 change: 1 addition & 0 deletions tests/testthat/test-limpiar.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

context("limpieza")

testthat::test_that("listas son eliminadas de datos de contactos", {
Expand Down

0 comments on commit ced9b33

Please sign in to comment.