From 8ccd21b72266fb64cddd6471e229a4e28a64d60f Mon Sep 17 00:00:00 2001 From: FvD Date: Tue, 26 May 2020 16:15:02 -0600 Subject: [PATCH 1/3] Setup FvD as maintainer --- DESCRIPTION | 25 ++++++++++++++++--------- LICENSE | 2 +- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 011b8e0..46c7f75 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -8,27 +8,35 @@ Authors@R: c( email = "hola@ixpantia.com"), person(given = "Ronny", family = "Hernández Mora", - role = c("cre", "aut"), + role = c("aut"), email = "ronny@ixpantia.com", comment = c(ORCID = "0000-0001-6225-7096")), person(given = "Frans", family = "van Dunné", - role = "aut", - email="frans@ixpantia.com")) + role = c("cre", "aut"), + email = "frans@ixpantia.com", + comment = c(ORCID = "0000-0002-7853-2811"))) Description: Connect to the Less Annoying CRM API to get your data clean and tidy. -License: GPL + file LICENCE +License: GPL-2 + file LICENCE URL: https://ixpantia.github.io/lacrmr/ BugReports: https://github.com/ixpantia/lacrmr/issues Encoding: UTF-8 LazyData: true -RoxygenNote: 7.0.2 +RoxygenNote: 7.1.0 Depends: R (>= 3.6), - magrittr + magrittr, + dplyr, + httr, + jsonlite, + janitor, + sjmisc Suggests: testthat (>= 2.1.0), knitr, - rmarkdown + rmarkdown, + httptest, + mockery VignetteBuilder: knitr Repository: ixprepo Imports: @@ -36,5 +44,4 @@ Imports: httr, jsonlite, janitor, - sjmisc, - httptest + sjmisc diff --git a/LICENSE b/LICENSE index 97f79a1..4580134 100644 --- a/LICENSE +++ b/LICENSE @@ -1,2 +1,2 @@ -YEAR: 2019 +YEAR: 2019-2020 COPYRIGHT HOLDER: ixpantia, S.R.L. From e4afe7c6a5c59767ae7bb3439861c33ae6631979 Mon Sep 17 00:00:00 2001 From: FvD Date: Tue, 26 May 2020 16:15:17 -0600 Subject: [PATCH 2/3] minor changes to pass checks --- R/utils.R | 2 -- man/get_request.Rd | 3 --- tests/testthat.R | 1 + 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/R/utils.R b/R/utils.R index 8f6f6ae..ddb8745 100644 --- a/R/utils.R +++ b/R/utils.R @@ -1,6 +1,4 @@ #' GET call to lacrm API -#' @param x an integer -#' @NoRd get_request <- function(user_code, api_token, api_function, ...) { item <- paste0(...) diff --git a/man/get_request.Rd b/man/get_request.Rd index 4557060..24c83da 100644 --- a/man/get_request.Rd +++ b/man/get_request.Rd @@ -6,9 +6,6 @@ \usage{ get_request(user_code, api_token, api_function, ...) } -\arguments{ -\item{x}{an integer} -} \description{ GET call to lacrm API } diff --git a/tests/testthat.R b/tests/testthat.R index dcc76bc..f21f904 100644 --- a/tests/testthat.R +++ b/tests/testthat.R @@ -1,4 +1,5 @@ library(testthat) library(lacrmr) +library(httptest) test_check("lacrmr") From c01fba3897f6b82e4b7261d7ce5a830008dccc0e Mon Sep 17 00:00:00 2001 From: FvD Date: Tue, 26 May 2020 16:24:27 -0600 Subject: [PATCH 3/3] Check with zero warnings --- DESCRIPTION | 11 +++-------- R/get_account_information.R | 2 ++ R/get_contact_information.R | 2 ++ R/search_contacts.R | 2 ++ man/get_request.Rd | 11 ----------- 5 files changed, 9 insertions(+), 19 deletions(-) delete mode 100644 man/get_request.Rd diff --git a/DESCRIPTION b/DESCRIPTION index df4dedb..b0b953f 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -25,12 +25,7 @@ LazyData: true RoxygenNote: 7.1.0 Depends: R (>= 3.6), - magrittr, - dplyr, - httr, - jsonlite, - janitor, - sjmisc + magrittr Suggests: testthat (>= 2.1.0), knitr, @@ -38,10 +33,10 @@ Suggests: httptest, mockery VignetteBuilder: knitr -Repository: ixprepo Imports: dplyr, httr, jsonlite, janitor, - sjmisc + sjmisc, + stringr diff --git a/R/get_account_information.R b/R/get_account_information.R index da66358..e7ca3f2 100644 --- a/R/get_account_information.R +++ b/R/get_account_information.R @@ -1,4 +1,6 @@ #' @import magrittr +NULL + #' #' @title get_account_information #' diff --git a/R/get_contact_information.R b/R/get_contact_information.R index 52e1350..3f53f48 100644 --- a/R/get_contact_information.R +++ b/R/get_contact_information.R @@ -1,4 +1,6 @@ #' @import magrittr +NULL + #' #' @title get_contact_information #' diff --git a/R/search_contacts.R b/R/search_contacts.R index a9de7fd..ace7029 100644 --- a/R/search_contacts.R +++ b/R/search_contacts.R @@ -1,4 +1,6 @@ #' @import magrittr +NULL + #' #' @title search_contacts #' diff --git a/man/get_request.Rd b/man/get_request.Rd deleted file mode 100644 index 24c83da..0000000 --- a/man/get_request.Rd +++ /dev/null @@ -1,11 +0,0 @@ -% Generated by roxygen2: do not edit by hand -% Please edit documentation in R/utils.R -\name{get_request} -\alias{get_request} -\title{GET call to lacrm API} -\usage{ -get_request(user_code, api_token, api_function, ...) -} -\description{ -GET call to lacrm API -}