Server API: Get status #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izzzzzi
commented
Feb 19, 2025
izzzzzi
commented
- Implement get_status() method in sync and async ServerApi
- Create Server model to represent server status
- Update demo.py with server status and database backup examples
- Add Server import to init.py
- Fix minor typos in demo.py comments
added 2 commits
February 19, 2025 16:50
* Implement get_status() method in sync and async ServerApi * Create Server model to represent server status * Update demo.py with server status and database backup examples * Add Server import to __init__.py * Fix minor typos in demo.py comments
* Add comprehensive tests for get_status() in sync and async APIs * Implement tests for get_db() method with successful and error scenarios * Use requests_mock and httpx_mock for mocking API responses * Improve test coverage for server-related API methods
|
@izzzzzi, hello! Thank you for contributing to the project! Please, fix You can also use them locally before pushing the next commits: pip install mypy
pip install pylintmypy py3xui
pylint py3xuiLooking forward to hearing from you. Thank you |
iwatkot
changed the title
* Improve server status API methods in sync and async APIs * Add headers and data handling for server status requests * Update Server model with more robust field mappings * Modify demo.py to use simplified email variable * Add QR code directory creation logic * Update .gitignore to exclude QR code and database files
* Enhance test_api.py and test_async_api.py with more comprehensive server status response * Update server status test mocks to include additional fields like CPU cores, network stats, and Xray information * Modify exception handling in test_get_db_failed to use requests.exceptions.HTTPError
|
@izzzzzi, hey! I would suggest to comment the get_db test function back because it does exactly the same thing as before and crashes the tests. :D |
* Load server status response from external JSON file in both sync and async tests * Update test_api.py and test_async_api.py to use shared response file * Adjust URL endpoints and assertion values to match new response data * Simplify test mocking and improve test readability
* Replace hardcoded response dictionaries with JSON file loading in test_api.py and test_async_api.py * Use ApiFields constants for consistent response key references * Remove commented region markers and unnecessary imports * Standardize response loading for client traffic and other test scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.