-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stream_settings optional in Inbound model #35
Conversation
@F1bos, hello! Thank you for the PR! Automatic checks are failing: py3xui/inbound/inbound.py:106: error: Item "str" of "StreamSettings | str" has no attribute "model_dump_json" [union-attr] Please update the corresponding method, otherwise it will fail with AttributeError. Sincerely |
Hi, @iwatkot 39 passed in 0.56s |
@F1bos, please fix the pylint errors: py3xui/inbound/inbound.py:62:0: C0301: Line too long (114/100) (line-too-long)
py3xui/inbound/inbound.py:114:52: E1101: Instance of 'FieldInfo' has no 'model_dump_json' member (no-member) And I'm merging it. Thank you |
@iwatkot Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) 39 passed in 0.58s |
@iwatkot fixed type comment 🥶 |
@F1bos, thanks for contributing! The new release is ready. Sincerely |
Sometimes stream_settings can be an empty string, for example if inbound is socks proxy. Right now methods related to inbound will fail if it's socks inbound. This pull request fixes it.
Code to reproduce:
Create a socks inbound and try running this code, it will fail with this exception: